cf9899c518
As per go/postdelayedtask-precision-in-webrtc we want to reduce the precision of PostDelayedTask() in order to schedule work on the CPU more efficiently. In order not to break "high precision" use cases, a new API is added to allow opting in to high precision. PostDelayedHighPrecisionTask() has the same precision that PostDelayedTask() has today, but by changing the interface's requirements on PostDelayedTask(), adding the high precision version of it will unblock making the old PostDelayedTask() API lower precision. This CL does not update implementations to support low precision so until those are updated, both PostDelayedTask() and PostDelayedHighPrecisionTask() have the same precision (=high). This CL also adds TODOs to make some rtc::Thread-specific versions of PostTask/PostDelayedTask obsolete, see https://crbug.com/webrtc/13582 for more info. Bug: webrtc:13583, webrtc:13582 Change-Id: I4c6d53d22bb299c49893ce9f3ef73a40d8c75de1 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/247367 Reviewed-by: Markus Handell <handellm@webrtc.org> Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org> Commit-Queue: Henrik Boström <hbos@webrtc.org> Cr-Commit-Position: refs/heads/main@{#35748}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.