zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
d43c692ba7f53b5576a494c0343bc7a4bb36831b
platform-external-webrtc/modules/video_coding
History
JT Teh 5daeff9c1f Revert "Remove RTPVideoHeader::h264() accessors." 
This reverts commit dfbced6504720d2c0807d7b92798eb80ba3f8be9.

Reason for revert: Crashes when making a video call.

#9	0x00000001043dd8d8 in webrtc::RTPVideoHeaderH264& absl::variant_internal::TypedThrowBadVariantAccess<webrtc::RTPVideoHeaderH264&>() at /third_party/absl/types/internal/variant.h:315
#10	0x00000001043dd8ac in absl::variant_internal::VariantAccessResultImpl<2ul, absl::variant<webrtc::RTPVideoHeaderVP8, webrtc::RTPVideoHeaderVP9, webrtc::RTPVideoHeaderH264>&&&>::type absl::variant_internal::VariantCoreAccess::CheckedAccess<2ul, absl::variant<webrtc::RTPVideoHeaderVP8, webrtc::RTPVideoHeaderVP9, webrtc::RTPVideoHeaderH264>&>(absl::variant<webrtc::RTPVideoHeaderVP8, webrtc::RTPVideoHeaderVP9, webrtc::RTPVideoHeaderH264>&&&) at /third_party/absl/types/internal/variant.h:597
#11	0x00000001043db778 in webrtc::RTPVideoHeaderH264& absl::get<webrtc::RTPVideoHeaderH264, webrtc::RTPVideoHeaderVP8, webrtc::RTPVideoHeaderVP9, webrtc::RTPVideoHeaderH264>(absl::variant<webrtc::RTPVideoHeaderVP8, webrtc::RTPVideoHeaderVP9, webrtc::RTPVideoHeaderH264>&) at /third_party/absl/types/variant.h:299
#12	0x0000000104558bcc in webrtc::RtpPacketizer::Create(webrtc::VideoCodecType, unsigned long, unsigned long, webrtc::RTPVideoHeader const*, webrtc::FrameType) at webrtc/modules/rtp_rtcp/source/rtp_format.cc:30

Original change's description:
> Remove RTPVideoHeader::h264() accessors.
>
> Bug: none
> Change-Id: I043bcaf358575688b223bc3631506e148b47fd58
> Reviewed-on: https://webrtc-review.googlesource.com/88220
> Reviewed-by: Stefan Holmer <stefan@webrtc.org>
> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
> Commit-Queue: Philip Eliasson <philipel@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#23971}

TBR=danilchap@webrtc.org,stefan@webrtc.org,philipel@webrtc.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: none
Change-Id: If99bcabdfe3cae7094f24e407bbe2f47233e46e3
Reviewed-on: https://webrtc-review.googlesource.com/88820
Commit-Queue: JT Teh <jtteh@webrtc.org>
Reviewed-by: Zeke Chin <tkchin@webrtc.org>
Reviewed-by: JT Teh <jtteh@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23993}
2018-07-16 21:36:12 +00:00
..
codecs
Add color space information to webrtc::VideoFrame and extract from VP9
2018-07-16 17:28:17 +00:00
include
Generalize SimulcastEncoderAdapter, use for H264 & VP8.
2018-06-21 15:57:43 +00:00
test
Reformat the WebRTC code base
2018-06-19 14:00:39 +00:00
utility
Stop using VideoCodec.targetBitrate for vp8 screenshare config
2018-07-06 15:13:18 +00:00
BUILD.gn
Add color space information to webrtc::VideoFrame and extract from VP9
2018-07-16 17:28:17 +00:00
codec_timer.cc
Fix chromium warnings for SdpVideoFormat.
2018-03-27 08:11:21 +00:00
codec_timer.h
Fix chromium warnings for SdpVideoFormat.
2018-03-27 08:11:21 +00:00
decoder_database.cc
Remove unused methods in VCMDecoderDataBase.
2018-06-07 08:46:57 +00:00
decoder_database.h
Remove unused methods in VCMDecoderDataBase.
2018-06-07 08:46:57 +00:00
decoding_state_unittest.cc
Add accessors to the types in the RTPVideoTypeHeader in RTPVideoHeader.
2018-07-05 14:29:07 +00:00
decoding_state.cc
Revert "Add Timestamp accessor methods to the EncodedImage class."
2018-06-26 11:52:45 +00:00
decoding_state.h
Adding NOLINT for typedefs.h and common_types.h
2017-09-15 13:03:51 +00:00
DEPS
Prepare VideoProcessor for async simulcast support.
2018-03-08 17:41:13 +00:00
encoded_frame.cc
Add accessors to the types in the RTPVideoTypeHeader in RTPVideoHeader.
2018-07-05 14:29:07 +00:00
encoded_frame.h
Delete unused copy constructors for VCMEncodedFrame and VCMFrameBuffer.
2018-06-26 14:34:15 +00:00
encoder_database.cc
Delete RTP-specific values from the VideoCodecType enum.
2018-06-07 07:49:27 +00:00
encoder_database.h
Delete payload_type from VCMEncoderDatabase and vcm::VideoSender.
2018-03-16 13:43:01 +00:00
fec_controller_default.cc
Revert "Revert "Enables PeerConnectionFactory using external fec controller""
2018-02-20 12:41:55 +00:00
fec_controller_default.h
Revert "Revert "Enables PeerConnectionFactory using external fec controller""
2018-02-20 12:41:55 +00:00
fec_controller_unittest.cc
Make fec controller plug-able.
2018-01-22 11:48:16 +00:00
fec_rate_table.h
…
frame_buffer2_unittest.cc
Revert "Add Timestamp accessor methods to the EncodedImage class."
2018-06-26 11:52:45 +00:00
frame_buffer2.cc
Revert "Add Timestamp accessor methods to the EncodedImage class."
2018-06-26 11:52:45 +00:00
frame_buffer2.h
Fix chromium warnings for SdpVideoFormat.
2018-03-27 08:11:21 +00:00
frame_buffer.cc
Delete unused copy constructors for VCMEncodedFrame and VCMFrameBuffer.
2018-06-26 14:34:15 +00:00
frame_buffer.h
Delete unused copy constructors for VCMEncodedFrame and VCMFrameBuffer.
2018-06-26 14:34:15 +00:00
frame_object.cc
Change RTPVideoTypeHeader to absl::variant and move RTPVideoHeader into its own h/cc file.
2018-07-10 11:57:46 +00:00
frame_object.h
Revert "Add Timestamp accessor methods to the EncodedImage class."
2018-06-26 11:52:45 +00:00
generic_decoder.cc
Revert "Add Timestamp accessor methods to the EncodedImage class."
2018-06-26 11:52:45 +00:00
generic_decoder.h
Reformat the WebRTC code base
2018-06-19 14:00:39 +00:00
generic_encoder_unittest.cc
Cleanup webrtc:: namespace from leaked TimingFrameFlags
2018-06-05 13:52:04 +00:00
generic_encoder.cc
Reformat the WebRTC code base
2018-06-19 14:00:39 +00:00
generic_encoder.h
Replace rtc::Optional with absl::optional
2018-06-18 10:24:48 +00:00
h264_sprop_parameter_sets_unittest.cc
…
h264_sprop_parameter_sets.cc
Delete unneeded includes of basictypes.h.
2018-05-21 19:35:08 +00:00
h264_sprop_parameter_sets.h
…
h264_sps_pps_tracker_unittest.cc
Revert "Remove RTPVideoHeader::h264() accessors."
2018-07-16 21:36:12 +00:00
h264_sps_pps_tracker.cc
Revert "Remove RTPVideoHeader::h264() accessors."
2018-07-16 21:36:12 +00:00
h264_sps_pps_tracker.h
…
histogram_unittest.cc
…
histogram.cc
Move sequence_number_utils.h to rtc_base/
2017-10-25 12:33:57 +00:00
histogram.h
…
inter_frame_delay.cc
…
inter_frame_delay.h
Adding NOLINT for typedefs.h and common_types.h
2017-09-15 13:03:51 +00:00
internal_defines.h
Adding NOLINT for typedefs.h and common_types.h
2017-09-15 13:03:51 +00:00
jitter_buffer_common.h
Moved NackModule and VCMPacket to their own targets
2018-06-15 09:00:25 +00:00
jitter_buffer_unittest.cc
Revert "Remove RTPVideoHeader::h264() accessors."
2018-07-16 21:36:12 +00:00
jitter_buffer.cc
Add accessors to the types in the RTPVideoTypeHeader in RTPVideoHeader.
2018-07-05 14:29:07 +00:00
jitter_buffer.h
Moved NackModule and VCMPacket to their own targets
2018-06-15 09:00:25 +00:00
jitter_estimator_tests.cc
…
jitter_estimator.cc
Reformat the WebRTC code base
2018-06-19 14:00:39 +00:00
jitter_estimator.h
Adding NOLINT for typedefs.h and common_types.h
2017-09-15 13:03:51 +00:00
media_opt_util.cc
Add experimental shortened 2-temporal-layer setting
2018-07-04 09:25:21 +00:00
media_opt_util.h
Adding NOLINT for typedefs.h and common_types.h
2017-09-15 13:03:51 +00:00
media_optimization.cc
Reformat the WebRTC code base
2018-06-19 14:00:39 +00:00
media_optimization.h
Revert "Revert "Enables PeerConnectionFactory using external fec controller""
2018-02-20 12:41:55 +00:00
nack_fec_tables.h
…
nack_module_unittest.cc
…
nack_module.cc
Simplify RtpVideoStreamReceiver::NotifyReceiverOfFecPacket.
2018-03-23 14:34:48 +00:00
nack_module.h
Reformat the WebRTC code base
2018-06-19 14:00:39 +00:00
OWNERS
Add philipel to modules/video_coding/OWNERS.
2018-05-17 10:14:31 +00:00
packet_buffer.cc
Revert "Remove RTPVideoHeader::h264() accessors."
2018-07-16 21:36:12 +00:00
packet_buffer.h
Replace rtc::Optional with absl::optional
2018-06-18 10:24:48 +00:00
packet.cc
VCMPacket: Set VCMNaluCompleteness for generic codecs
2018-07-11 13:22:59 +00:00
packet.h
VCMPacket: Set VCMNaluCompleteness for generic codecs
2018-07-11 13:22:59 +00:00
qp_parser.cc
Adding NOLINT for typedefs.h and common_types.h
2017-09-15 13:03:51 +00:00
qp_parser.h
…
receiver_unittest.cc
…
receiver.cc
Revert "Add Timestamp accessor methods to the EncodedImage class."
2018-06-26 11:52:45 +00:00
receiver.h
…
rtp_frame_reference_finder_unittest.cc
Unwrap TL0 pic index to avoid having to work with a wrapped number.
2018-07-06 13:28:38 +00:00
rtp_frame_reference_finder.cc
Change RTPVideoTypeHeader to absl::variant and move RTPVideoHeader into its own h/cc file.
2018-07-10 11:57:46 +00:00
rtp_frame_reference_finder.h
Unwrap TL0 pic index to avoid having to work with a wrapped number.
2018-07-06 13:28:38 +00:00
rtt_filter.cc
Fix typo in VCMRttFilter
2018-01-26 10:59:56 +00:00
rtt_filter.h
Adding NOLINT for typedefs.h and common_types.h
2017-09-15 13:03:51 +00:00
session_info_unittest.cc
VCMPacket: Set VCMNaluCompleteness for generic codecs
2018-07-11 13:22:59 +00:00
session_info.cc
Revert "Remove RTPVideoHeader::h264() accessors."
2018-07-16 21:36:12 +00:00
session_info.h
Delete unused methods in VCMFrameBuffer and VCMSessionInfo.
2018-06-11 18:39:50 +00:00
timestamp_map.cc
…
timestamp_map.h
Adding NOLINT for typedefs.h and common_types.h
2017-09-15 13:03:51 +00:00
timing_unittest.cc
Remove unused functions in VCMTiming.
2018-01-17 14:47:10 +00:00
timing.cc
Replace rtc::Optional with absl::optional
2018-06-18 10:24:48 +00:00
timing.h
Replace rtc::Optional with absl::optional
2018-06-18 10:24:48 +00:00
video_codec_initializer_unittest.cc
Stop using VideoCodec.targetBitrate for vp8 screenshare config
2018-07-06 15:13:18 +00:00
video_codec_initializer.cc
Stop using VideoCodec.targetBitrate for vp8 screenshare config
2018-07-06 15:13:18 +00:00
video_coding_defines.cc
Fix chromium warnings for SdpVideoFormat.
2018-03-27 08:11:21 +00:00
video_coding_impl.cc
Generalize SimulcastEncoderAdapter, use for H264 & VP8.
2018-06-21 15:57:43 +00:00
video_coding_impl.h
Reformat the WebRTC code base
2018-06-19 14:00:39 +00:00
video_packet_buffer_unittest.cc
Revert "Remove RTPVideoHeader::h264() accessors."
2018-07-16 21:36:12 +00:00
video_receiver_unittest.cc
Revert "Remove RTPVideoHeader::h264() accessors."
2018-07-16 21:36:12 +00:00
video_receiver.cc
Reformat the WebRTC code base
2018-06-19 14:00:39 +00:00
video_sender_unittest.cc
Add experimental shortened 2-temporal-layer setting
2018-07-04 09:25:21 +00:00
video_sender.cc
Generalize SimulcastEncoderAdapter, use for H264 & VP8.
2018-06-21 15:57:43 +00:00