d629314396
I420Buffer implementations (I420BufferImpl and WrappedNativeI420Buffer) rely on the 'position' of the underlying ByteBuffers to indicate the start of Y, U, and V channels. Returning slices prevents callers from altering the state of the I420Buffer by changing the position. ByteBuffers are especially prone to accidentally moving the position: relative read operations (such as get()) increment the position by the size of data read. BUG=webrtc:8303 Change-Id: I52edce8a3bf46a6c41980ff5110a9480f021f22f Reviewed-on: https://webrtc-review.googlesource.com/4521 Commit-Queue: Bjorn Mellem <mellem@webrtc.org> Reviewed-by: Sami Kalliomäki <sakal@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20050}
110 lines
2.6 KiB
Java
110 lines
2.6 KiB
Java
/*
|
|
* Copyright 2017 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
package org.webrtc;
|
|
|
|
import java.nio.ByteBuffer;
|
|
|
|
/**
|
|
* This class wraps a webrtc::I420BufferInterface into a VideoFrame.I420Buffer.
|
|
*/
|
|
class WrappedNativeI420Buffer implements VideoFrame.I420Buffer {
|
|
private final int width;
|
|
private final int height;
|
|
private final ByteBuffer dataY;
|
|
private final int strideY;
|
|
private final ByteBuffer dataU;
|
|
private final int strideU;
|
|
private final ByteBuffer dataV;
|
|
private final int strideV;
|
|
private final long nativeBuffer;
|
|
|
|
WrappedNativeI420Buffer(int width, int height, ByteBuffer dataY, int strideY, ByteBuffer dataU,
|
|
int strideU, ByteBuffer dataV, int strideV, long nativeBuffer) {
|
|
this.width = width;
|
|
this.height = height;
|
|
this.dataY = dataY;
|
|
this.strideY = strideY;
|
|
this.dataU = dataU;
|
|
this.strideU = strideU;
|
|
this.dataV = dataV;
|
|
this.strideV = strideV;
|
|
this.nativeBuffer = nativeBuffer;
|
|
|
|
retain();
|
|
}
|
|
|
|
@Override
|
|
public int getWidth() {
|
|
return width;
|
|
}
|
|
|
|
@Override
|
|
public int getHeight() {
|
|
return height;
|
|
}
|
|
|
|
@Override
|
|
public ByteBuffer getDataY() {
|
|
// Return a slice to prevent relative reads from changing the position.
|
|
return dataY.slice();
|
|
}
|
|
|
|
@Override
|
|
public ByteBuffer getDataU() {
|
|
// Return a slice to prevent relative reads from changing the position.
|
|
return dataU.slice();
|
|
}
|
|
|
|
@Override
|
|
public ByteBuffer getDataV() {
|
|
// Return a slice to prevent relative reads from changing the position.
|
|
return dataV.slice();
|
|
}
|
|
|
|
@Override
|
|
public int getStrideY() {
|
|
return strideY;
|
|
}
|
|
|
|
@Override
|
|
public int getStrideU() {
|
|
return strideU;
|
|
}
|
|
|
|
@Override
|
|
public int getStrideV() {
|
|
return strideV;
|
|
}
|
|
|
|
@Override
|
|
public VideoFrame.I420Buffer toI420() {
|
|
retain();
|
|
return this;
|
|
}
|
|
|
|
@Override
|
|
public void retain() {
|
|
JniCommon.nativeAddRef(nativeBuffer);
|
|
}
|
|
|
|
@Override
|
|
public void release() {
|
|
JniCommon.nativeReleaseRef(nativeBuffer);
|
|
}
|
|
|
|
@Override
|
|
public VideoFrame.Buffer cropAndScale(
|
|
int cropX, int cropY, int cropWidth, int cropHeight, int scaleWidth, int scaleHeight) {
|
|
return VideoFrame.cropAndScaleI420(
|
|
this, cropX, cropY, cropWidth, cropHeight, scaleWidth, scaleHeight);
|
|
}
|
|
}
|