d70d80d882
SVC support is limited: During SVC testing there is no SFU, so framework will try to emulate SFU behavior in regular p2p call. Because of it there are such limitations: * if |target_spatial_index| is not equal to the highest spatial layer then no packet/frame drops are allowed. If there will be any drops, that will affect requested layer, then WebRTC SVC implementation will continue decoding only the highest available layer and won't restore lower layers, so analyzer won't receive required data which will cause wrong results or test failures. Bug: webrtc:10138 Change-Id: I079566260ca9f1815935bce365d1bca10766663a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/144882 Commit-Queue: Artem Titov <titovartem@webrtc.org> Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Stefan Holmer <stefan@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28612}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.