dab3ce8f29
This reverts commit 49c293f03d8f593aa3aca282577fcb14daa63207. Reason for revert: Downstream updated Original change's description: > Revert "Removed VideoDecoderFactory::LegacyCreateVideoDecoder and VideoReceiveStream::Config::stream_id." > > This reverts commit 4ba1044bae750ab8ee47b359c21f672386b7c3cd. > > Reason for revert: Downstream projects require some updates. > > Original change's description: > > Removed VideoDecoderFactory::LegacyCreateVideoDecoder and VideoReceiveStream::Config::stream_id. > > > > Bug: webrtc:9106 > > Change-Id: I7fa84095732c33d136a9354ae4f09266cffcf877 > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/180020 > > Reviewed-by: Henrik Andreassson <henrika@webrtc.org> > > Commit-Queue: Philip Eliasson <philipel@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#31793} > > TBR=henrika@webrtc.org,magjed@webrtc.org,philipel@webrtc.org,mflodman@webrtc.org > > Change-Id: I8c980266334cc9871b9076713da3c4df8f73f8ce > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: webrtc:9106 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/180344 > Reviewed-by: Philip Eliasson <philipel@webrtc.org> > Commit-Queue: Philip Eliasson <philipel@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#31794} # Not skipping CQ checks because original CL landed > 1 day ago. Bug: webrtc:9106 Change-Id: I52923c0f3952832c50a7d73b466775b8c5d541cb Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/216329 Reviewed-by: Philip Eliasson <philipel@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Philip Eliasson <philipel@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33884}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.