dba4db5668
This reverts commit 18515e2793fbcfce358a1c650da6cb552ca59ac5. Reason for revert: Continuation of previous revert https://webrtc-review.googlesource.com/c/src/+/186304 Original change's description: > Reland "Reduce the amount of howling reduction in AEC3" > > This is a reland of 2978abb88c49362e296bdce3cb662f6255b17083 > > Original change's description: > > Reduce the amount of howling reduction in AEC3 > > > > This CL backs off the howling protection functionality in AEC3. > > The effect is increased transparency in some cases. No negative effects > > have been identified in the hands-on testing. > > > > > > A kill-switch is added that can be used to turn off the functionality. > > > > Bug: b/150764764 > > Change-Id: I604c569c76f911799556a60bc8fd2fb43bbfe196 > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/186082 > > Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org> > > Commit-Queue: Per Åhgren <peah@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#32258} > > Bug: b/150764764 > Change-Id: I277f24eb3288ad0307e7463bad9aea6436cfe879 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/186263 > Reviewed-by: Per Åhgren <peah@webrtc.org> > Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org> > Commit-Queue: Per Åhgren <peah@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#32274} TBR=gustaf@webrtc.org,peah@webrtc.org Change-Id: I0596855e3bf910878aebcee90e03345d5db1105d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b/150764764 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/186269 Reviewed-by: Andrey Logvin <landrey@webrtc.org> Commit-Queue: Andrey Logvin <landrey@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32276}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.