36f8f3eaab
Changes places where we explicitly construct an Optional to instead use nullopt or the requisite value type only. This CL was uploaded by git cl split. TBR=pthatcher@webrtc.org Bug: None Change-Id: If41c462dc3ddff664d0b70d249d760e2ca4c8ab3 Reviewed-on: https://webrtc-review.googlesource.com/23576 Commit-Queue: Oskar Sundbom <ossu@webrtc.org> Reviewed-by: Steve Anton <steveanton@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20820}
107 lines
3.9 KiB
C++
107 lines
3.9 KiB
C++
/*
|
|
* Copyright 2013 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#include "pc/localaudiosource.h"
|
|
|
|
#include <string>
|
|
#include <vector>
|
|
|
|
#include "api/test/fakeconstraints.h"
|
|
#include "media/base/fakemediaengine.h"
|
|
#include "media/base/fakevideorenderer.h"
|
|
#include "rtc_base/gunit.h"
|
|
|
|
using webrtc::LocalAudioSource;
|
|
using webrtc::MediaConstraintsInterface;
|
|
using webrtc::MediaSourceInterface;
|
|
|
|
TEST(LocalAudioSourceTest, SetValidOptions) {
|
|
webrtc::FakeConstraints constraints;
|
|
constraints.AddMandatory(
|
|
MediaConstraintsInterface::kGoogEchoCancellation, false);
|
|
constraints.AddOptional(
|
|
MediaConstraintsInterface::kExtendedFilterEchoCancellation, true);
|
|
constraints.AddOptional(MediaConstraintsInterface::kDAEchoCancellation, true);
|
|
constraints.AddOptional(MediaConstraintsInterface::kAutoGainControl, true);
|
|
constraints.AddOptional(
|
|
MediaConstraintsInterface::kExperimentalAutoGainControl, true);
|
|
constraints.AddMandatory(MediaConstraintsInterface::kNoiseSuppression, false);
|
|
constraints.AddOptional(MediaConstraintsInterface::kHighpassFilter, true);
|
|
|
|
rtc::scoped_refptr<LocalAudioSource> source =
|
|
LocalAudioSource::Create(&constraints);
|
|
|
|
EXPECT_EQ(false, source->options().echo_cancellation);
|
|
EXPECT_EQ(true, source->options().extended_filter_aec);
|
|
EXPECT_EQ(true, source->options().delay_agnostic_aec);
|
|
EXPECT_EQ(true, source->options().auto_gain_control);
|
|
EXPECT_EQ(true, source->options().experimental_agc);
|
|
EXPECT_EQ(false, source->options().noise_suppression);
|
|
EXPECT_EQ(true, source->options().highpass_filter);
|
|
}
|
|
|
|
TEST(LocalAudioSourceTest, OptionNotSet) {
|
|
webrtc::FakeConstraints constraints;
|
|
rtc::scoped_refptr<LocalAudioSource> source =
|
|
LocalAudioSource::Create(&constraints);
|
|
EXPECT_EQ(rtc::nullopt, source->options().highpass_filter);
|
|
}
|
|
|
|
TEST(LocalAudioSourceTest, MandatoryOverridesOptional) {
|
|
webrtc::FakeConstraints constraints;
|
|
constraints.AddMandatory(
|
|
MediaConstraintsInterface::kGoogEchoCancellation, false);
|
|
constraints.AddOptional(
|
|
MediaConstraintsInterface::kGoogEchoCancellation, true);
|
|
|
|
rtc::scoped_refptr<LocalAudioSource> source =
|
|
LocalAudioSource::Create(&constraints);
|
|
|
|
EXPECT_EQ(false, source->options().echo_cancellation);
|
|
}
|
|
|
|
TEST(LocalAudioSourceTest, InvalidOptional) {
|
|
webrtc::FakeConstraints constraints;
|
|
constraints.AddOptional(MediaConstraintsInterface::kHighpassFilter, false);
|
|
constraints.AddOptional("invalidKey", false);
|
|
|
|
rtc::scoped_refptr<LocalAudioSource> source =
|
|
LocalAudioSource::Create(&constraints);
|
|
|
|
EXPECT_EQ(MediaSourceInterface::kLive, source->state());
|
|
EXPECT_EQ(false, source->options().highpass_filter);
|
|
}
|
|
|
|
TEST(LocalAudioSourceTest, InvalidMandatory) {
|
|
webrtc::FakeConstraints constraints;
|
|
constraints.AddMandatory(MediaConstraintsInterface::kHighpassFilter, false);
|
|
constraints.AddMandatory("invalidKey", false);
|
|
|
|
rtc::scoped_refptr<LocalAudioSource> source =
|
|
LocalAudioSource::Create(&constraints);
|
|
|
|
EXPECT_EQ(MediaSourceInterface::kLive, source->state());
|
|
EXPECT_EQ(false, source->options().highpass_filter);
|
|
}
|
|
|
|
TEST(LocalAudioSourceTest, InitWithAudioOptions) {
|
|
cricket::AudioOptions audio_options;
|
|
audio_options.highpass_filter = true;
|
|
rtc::scoped_refptr<LocalAudioSource> source =
|
|
LocalAudioSource::Create(&audio_options);
|
|
EXPECT_EQ(true, source->options().highpass_filter);
|
|
}
|
|
|
|
TEST(LocalAudioSourceTest, InitWithNoOptions) {
|
|
rtc::scoped_refptr<LocalAudioSource> source =
|
|
LocalAudioSource::Create((cricket::AudioOptions*)nullptr);
|
|
EXPECT_EQ(rtc::nullopt, source->options().highpass_filter);
|
|
}
|