zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
e12e68cc4e816796ab67dce47d79dc86600d0de7
platform-external-webrtc/modules/rtp_rtcp/source
History
JT Teh 5daeff9c1f Revert "Remove RTPVideoHeader::h264() accessors." 
This reverts commit dfbced6504720d2c0807d7b92798eb80ba3f8be9.

Reason for revert: Crashes when making a video call.

#9	0x00000001043dd8d8 in webrtc::RTPVideoHeaderH264& absl::variant_internal::TypedThrowBadVariantAccess<webrtc::RTPVideoHeaderH264&>() at /third_party/absl/types/internal/variant.h:315
#10	0x00000001043dd8ac in absl::variant_internal::VariantAccessResultImpl<2ul, absl::variant<webrtc::RTPVideoHeaderVP8, webrtc::RTPVideoHeaderVP9, webrtc::RTPVideoHeaderH264>&&&>::type absl::variant_internal::VariantCoreAccess::CheckedAccess<2ul, absl::variant<webrtc::RTPVideoHeaderVP8, webrtc::RTPVideoHeaderVP9, webrtc::RTPVideoHeaderH264>&>(absl::variant<webrtc::RTPVideoHeaderVP8, webrtc::RTPVideoHeaderVP9, webrtc::RTPVideoHeaderH264>&&&) at /third_party/absl/types/internal/variant.h:597
#11	0x00000001043db778 in webrtc::RTPVideoHeaderH264& absl::get<webrtc::RTPVideoHeaderH264, webrtc::RTPVideoHeaderVP8, webrtc::RTPVideoHeaderVP9, webrtc::RTPVideoHeaderH264>(absl::variant<webrtc::RTPVideoHeaderVP8, webrtc::RTPVideoHeaderVP9, webrtc::RTPVideoHeaderH264>&) at /third_party/absl/types/variant.h:299
#12	0x0000000104558bcc in webrtc::RtpPacketizer::Create(webrtc::VideoCodecType, unsigned long, unsigned long, webrtc::RTPVideoHeader const*, webrtc::FrameType) at webrtc/modules/rtp_rtcp/source/rtp_format.cc:30

Original change's description:
> Remove RTPVideoHeader::h264() accessors.
>
> Bug: none
> Change-Id: I043bcaf358575688b223bc3631506e148b47fd58
> Reviewed-on: https://webrtc-review.googlesource.com/88220
> Reviewed-by: Stefan Holmer <stefan@webrtc.org>
> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
> Commit-Queue: Philip Eliasson <philipel@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#23971}

TBR=danilchap@webrtc.org,stefan@webrtc.org,philipel@webrtc.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: none
Change-Id: If99bcabdfe3cae7094f24e407bbe2f47233e46e3
Reviewed-on: https://webrtc-review.googlesource.com/88820
Commit-Queue: JT Teh <jtteh@webrtc.org>
Reviewed-by: Zeke Chin <tkchin@webrtc.org>
Reviewed-by: JT Teh <jtteh@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23993}
2018-07-16 21:36:12 +00:00
..
rtcp_packet
Reformat the WebRTC code base
2018-06-19 14:00:39 +00:00
byte_io_unittest.cc
Reformat the WebRTC code base
2018-06-19 14:00:39 +00:00
byte_io.h
Reformat the WebRTC code base
2018-06-19 14:00:39 +00:00
dtmf_queue.cc
…
dtmf_queue.h
…
fec_private_tables_bursty_unittest.cc
Fix a couple of nits and update a few comments in forward_error_correction_internal.
2018-04-23 14:29:17 +00:00
fec_private_tables_bursty.cc
Reformat the WebRTC code base
2018-06-19 14:00:39 +00:00
fec_private_tables_bursty.h
Move the FEC private tables into .cc files.
2018-04-04 15:16:10 +00:00
fec_private_tables_random.cc
Remove part of the FEC code table that covers FEC code for group of 13-48 media packets, instead generate interleaved FEC code at run time. FEC code masks for protection of group of 1 - 12 media packets is not changed.
2018-04-18 14:35:17 +00:00
fec_private_tables_random.h
Move the FEC private tables into .cc files.
2018-04-04 15:16:10 +00:00
fec_test_helper.cc
Change RTPVideoTypeHeader to absl::variant and move RTPVideoHeader into its own h/cc file.
2018-07-10 11:57:46 +00:00
fec_test_helper.h
Delete unneeded includes of basictypes.h.
2018-05-21 19:35:08 +00:00
flexfec_header_reader_writer_unittest.cc
Delete unneeded includes of basictypes.h.
2018-05-21 19:35:08 +00:00
flexfec_header_reader_writer.cc
Stop using LOG macros in favor of RTC_ prefixed macros.
2017-11-09 11:56:32 +00:00
flexfec_header_reader_writer.h
Delete unneeded includes of basictypes.h.
2018-05-21 19:35:08 +00:00
flexfec_receiver_unittest.cc
Delete unneeded includes of basictypes.h.
2018-05-21 19:35:08 +00:00
flexfec_receiver.cc
Avoid lifetime issues with FlexfecReceiver packet buffer.
2017-12-12 10:12:47 +00:00
flexfec_sender_unittest.cc
Reformat the WebRTC code base
2018-06-19 14:00:39 +00:00
flexfec_sender.cc
Add MID sending to FlexfecSender
2018-04-10 16:08:35 +00:00
forward_error_correction_internal.cc
Fix a downstream test failure.
2018-06-15 13:30:26 +00:00
forward_error_correction_internal.h
Fix a couple of nits and update a few comments in forward_error_correction_internal.
2018-04-23 14:29:17 +00:00
forward_error_correction.cc
Revert "Fix buffer overflow in ulpfec recovery"
2018-07-16 12:31:57 +00:00
forward_error_correction.h
Reformat the WebRTC code base
2018-06-19 14:00:39 +00:00
nack_rtx_unittest.cc
Reformat the WebRTC code base
2018-06-19 14:00:39 +00:00
packet_loss_stats_unittest.cc
…
packet_loss_stats.cc
Reformat the WebRTC code base
2018-06-19 14:00:39 +00:00
packet_loss_stats.h
Fix clang style errors in rtp_rtcp and dependant targets
2018-02-07 09:48:28 +00:00
playout_delay_oracle_unittest.cc
…
playout_delay_oracle.cc
…
playout_delay_oracle.h
…
receive_statistics_impl.cc
Remove StreamStatistician::IsPacketInOrder
2018-06-28 08:44:40 +00:00
receive_statistics_impl.h
Remove StreamStatistician::IsPacketInOrder
2018-06-28 08:44:40 +00:00
receive_statistics_unittest.cc
Update packetsLost and jitter stats any time a packet is received.
2018-06-25 23:56:39 +00:00
remote_ntp_time_estimator_unittest.cc
Reformat the WebRTC code base
2018-06-19 14:00:39 +00:00
remote_ntp_time_estimator.cc
Move timestamp_extrapolator.h to rtc_base/time/
2018-03-22 14:36:44 +00:00
rtcp_nack_stats_unittest.cc
Reformat the WebRTC code base
2018-06-19 14:00:39 +00:00
rtcp_nack_stats.cc
Reformat the WebRTC code base
2018-06-19 14:00:39 +00:00
rtcp_nack_stats.h
Reformat the WebRTC code base
2018-06-19 14:00:39 +00:00
rtcp_packet_unittest.cc
Change RtcpPacket::PacketReadyCallback to rtc::FunctionView
2017-12-07 11:20:08 +00:00
rtcp_packet.cc
Reformat the WebRTC code base
2018-06-19 14:00:39 +00:00
rtcp_packet.h
Delete unneeded includes of basictypes.h.
2018-05-21 19:35:08 +00:00
rtcp_receiver_unittest.cc
Reformat the WebRTC code base
2018-06-19 14:00:39 +00:00
rtcp_receiver.cc
Reformat the WebRTC code base
2018-06-19 14:00:39 +00:00
rtcp_receiver.h
Handle Receiver Reference Time Report from multiple receivers.
2018-04-16 09:54:07 +00:00
rtcp_sender_unittest.cc
Reformat the WebRTC code base
2018-06-19 14:00:39 +00:00
rtcp_sender.cc
Use absl::make_unique and absl::WrapUnique directly
2018-07-05 10:59:49 +00:00
rtcp_sender.h
Replace rtc::Optional with absl::optional in modules/rtp_rtcp
2018-06-15 09:53:35 +00:00
rtcp_transceiver_config.cc
Calculate RTT using ExtendedReports in RtcpTransceiver
2017-11-30 14:34:40 +00:00
rtcp_transceiver_config.h
Directly include VideoBitrateAllocation in modules/rtp_rtcp/ targets
2018-05-17 11:22:56 +00:00
rtcp_transceiver_impl_unittest.cc
Use absl::make_unique and absl::WrapUnique directly
2018-07-05 10:59:49 +00:00
rtcp_transceiver_impl.cc
Use absl::make_unique and absl::WrapUnique directly
2018-07-05 10:59:49 +00:00
rtcp_transceiver_impl.h
Replace rtc::Optional with absl::optional in modules/rtp_rtcp
2018-06-15 09:53:35 +00:00
rtcp_transceiver_unittest.cc
Use absl::make_unique and absl::WrapUnique directly
2018-07-05 10:59:49 +00:00
rtcp_transceiver.cc
Use absl::make_unique and absl::WrapUnique directly
2018-07-05 10:59:49 +00:00
rtcp_transceiver.h
Allow to turn RtcpTransciever on and off at runtime.
2018-03-06 15:19:11 +00:00
rtp_fec_unittest.cc
Reformat the WebRTC code base
2018-06-19 14:00:39 +00:00
rtp_format_h264_unittest.cc
Revert "Remove RTPVideoHeader::h264() accessors."
2018-07-16 21:36:12 +00:00
rtp_format_h264.cc
Revert "Remove RTPVideoHeader::h264() accessors."
2018-07-16 21:36:12 +00:00
rtp_format_h264.h
Don't crash in SingleNalu packetization for h264 if no space in packet
2018-03-15 15:42:57 +00:00
rtp_format_video_generic_unittest.cc
Reland "Add stereo codec header and pass it through RTP"
2017-11-30 01:44:19 +00:00
rtp_format_video_generic.cc
Add ParsedPayload::video_header() accessor.
2018-07-04 09:31:21 +00:00
rtp_format_video_generic.h
Fix clang style errors in rtp_rtcp and dependant targets
2018-02-07 09:48:28 +00:00
rtp_format_vp8_test_helper.cc
Reformat the WebRTC code base
2018-06-19 14:00:39 +00:00
rtp_format_vp8_test_helper.h
Adding NOLINT for typedefs.h and common_types.h
2017-09-15 13:03:51 +00:00
rtp_format_vp8_unittest.cc
Add accessors to the types in the RTPVideoTypeHeader in RTPVideoHeader.
2018-07-05 14:29:07 +00:00
rtp_format_vp8.cc
Add accessors to the types in the RTPVideoTypeHeader in RTPVideoHeader.
2018-07-05 14:29:07 +00:00
rtp_format_vp8.h
Reformat the WebRTC code base
2018-06-19 14:00:39 +00:00
rtp_format_vp9_unittest.cc
Add accessors to the types in the RTPVideoTypeHeader in RTPVideoHeader.
2018-07-05 14:29:07 +00:00
rtp_format_vp9.cc
Add accessors to the types in the RTPVideoTypeHeader in RTPVideoHeader.
2018-07-05 14:29:07 +00:00
rtp_format_vp9.h
Reformat the WebRTC code base
2018-06-19 14:00:39 +00:00
rtp_format.cc
Revert "Remove RTPVideoHeader::h264() accessors."
2018-07-16 21:36:12 +00:00
rtp_format.h
Add accessors to the types in the RTPVideoTypeHeader in RTPVideoHeader.
2018-07-05 14:29:07 +00:00
rtp_generic_frame_descriptor_extension_unittest.cc
Add Parsing/Building generic frame descriptor extension
2018-06-19 14:51:27 +00:00
rtp_generic_frame_descriptor_extension.cc
Add Generic frame descritpor header extension
2018-06-29 15:02:44 +00:00
rtp_generic_frame_descriptor_extension.h
Add Generic frame descritpor header extension
2018-06-29 15:02:44 +00:00
rtp_generic_frame_descriptor.cc
Discard frame self-dependency when parsing genric frame descriptor
2018-07-03 10:28:05 +00:00
rtp_generic_frame_descriptor.h
Add Parsing/Building generic frame descriptor extension
2018-06-19 14:51:27 +00:00
rtp_header_extension_map_unittest.cc
Adding NOLINT for typedefs.h and common_types.h
2017-09-15 13:03:51 +00:00
rtp_header_extension_map.cc
Add Generic frame descritpor header extension
2018-06-29 15:02:44 +00:00
rtp_header_extensions.cc
Pass buffer with size when writing rtp header extension
2018-06-18 13:04:33 +00:00
rtp_header_extensions.h
Pass buffer with size when writing rtp header extension
2018-06-18 13:04:33 +00:00
rtp_header_parser.cc
Fix clang style errors in rtp_rtcp and dependant targets
2018-02-07 09:48:28 +00:00
rtp_packet_history_unittest.cc
Replace rtc::Optional with absl::optional in modules/rtp_rtcp
2018-06-15 09:53:35 +00:00
rtp_packet_history.cc
Use absl::make_unique and absl::WrapUnique directly
2018-07-05 10:59:49 +00:00
rtp_packet_history.h
Replace rtc::Optional with absl::optional in modules/rtp_rtcp
2018-06-15 09:53:35 +00:00
rtp_packet_received.cc
Add move constructors and assignment operators to RtpPacketReceived and RtpPacketToSend. Since both are non-POD now, move would fall back to copy without these.
2018-02-26 13:25:50 +00:00
rtp_packet_received.h
Add move constructors and assignment operators to RtpPacketReceived and RtpPacketToSend. Since both are non-POD now, move would fall back to copy without these.
2018-02-26 13:25:50 +00:00
rtp_packet_to_send.cc
Add move constructors and assignment operators to RtpPacketReceived and RtpPacketToSend. Since both are non-POD now, move would fall back to copy without these.
2018-02-26 13:25:50 +00:00
rtp_packet_to_send.h
Add move constructors and assignment operators to RtpPacketReceived and RtpPacketToSend. Since both are non-POD now, move would fall back to copy without these.
2018-02-26 13:25:50 +00:00
rtp_packet_unittest.cc
Pass buffer with size when writing rtp header extension
2018-06-18 13:04:33 +00:00
rtp_packet.cc
Fix infinite loop in rtp packet parsing
2018-02-13 14:42:45 +00:00
rtp_packet.h
Pass buffer with size when writing rtp header extension
2018-06-18 13:04:33 +00:00
rtp_payload_registry_unittest.cc
Delete enum RtpVideoCodecTypes, replaced with VideoCodecType.
2018-06-04 11:53:17 +00:00
rtp_payload_registry.cc
Reformat the WebRTC code base
2018-06-19 14:00:39 +00:00
rtp_receiver_audio.cc
Clean up in module_common_types.h by removing the unused struct RTPAudioHeader.
2018-06-19 16:44:19 +00:00
rtp_receiver_audio.h
Clean up in module_common_types.h by removing the unused struct RTPAudioHeader.
2018-06-19 16:44:19 +00:00
rtp_receiver_impl.cc
Change RTPVideoTypeHeader to absl::variant and move RTPVideoHeader into its own h/cc file.
2018-07-10 11:57:46 +00:00
rtp_receiver_impl.h
Clean up in module_common_types.h by removing the unused struct RTPAudioHeader.
2018-06-19 16:44:19 +00:00
rtp_receiver_strategy.cc
Clean up in module_common_types.h by removing the unused struct RTPAudioHeader.
2018-06-19 16:44:19 +00:00
rtp_receiver_strategy.h
Clean up in module_common_types.h by removing the unused struct RTPAudioHeader.
2018-06-19 16:44:19 +00:00
rtp_receiver_unittest.cc
Delete RtpFeedback. The ssrc for a receive stream should be known at
2018-05-28 11:05:19 +00:00
rtp_receiver_video.cc
Add ParsedPayload::video_header() accessor.
2018-07-04 09:31:21 +00:00
rtp_receiver_video.h
Delete OnIncomingCSRCChanged and related code.
2018-03-27 13:18:35 +00:00
rtp_rtcp_config.h
Make RTCP report interval configurable
2018-02-01 10:12:11 +00:00
rtp_rtcp_impl_unittest.cc
Add accessors to the types in the RTPVideoTypeHeader in RTPVideoHeader.
2018-07-05 14:29:07 +00:00
rtp_rtcp_impl.cc
Reformat the WebRTC code base
2018-06-19 14:00:39 +00:00
rtp_rtcp_impl.h
Replace rtc::Optional with absl::optional in modules/rtp_rtcp
2018-06-15 09:53:35 +00:00
rtp_sender_audio.cc
Reformat the WebRTC code base
2018-06-19 14:00:39 +00:00
rtp_sender_audio.h
Remove use of RTPFragmentationHeader from RTPSenderAudio
2017-10-30 09:56:19 +00:00
rtp_sender_unittest.cc
Revert "Remove RTPVideoHeader::h264() accessors."
2018-07-16 21:36:12 +00:00
rtp_sender_video.cc
Always disable RED when ULPFEC is disabled.
2018-07-12 13:01:20 +00:00
rtp_sender_video.h
Replace rtc::Optional with absl::optional in modules/rtp_rtcp
2018-06-15 09:53:35 +00:00
rtp_sender.cc
Use absl::make_unique and absl::WrapUnique directly
2018-07-05 10:59:49 +00:00
rtp_sender.h
Replace rtc::Optional with absl::optional in modules/rtp_rtcp
2018-06-15 09:53:35 +00:00
rtp_utility_unittest.cc
…
rtp_utility.cc
Add Generic frame descritpor header extension
2018-06-29 15:02:44 +00:00
rtp_utility.h
Delete RtpFeedback. The ssrc for a receive stream should be known at
2018-05-28 11:05:19 +00:00
rtp_video_header.cc
Change RTPVideoTypeHeader to absl::variant and move RTPVideoHeader into its own h/cc file.
2018-07-10 11:57:46 +00:00
rtp_video_header.h
Revert "Remove RTPVideoHeader::h264() accessors."
2018-07-16 21:36:12 +00:00
time_util_unittest.cc
Delete assumption TimeMicrosToNtp can match RealTimeClock
2018-02-22 17:20:25 +00:00
time_util.cc
Add TimeMicrosToNtp to calculate current NtpTime without Clock
2017-11-28 10:11:58 +00:00
time_util.h
Delete assumption TimeMicrosToNtp can match RealTimeClock
2018-02-22 17:20:25 +00:00
tmmbr_help.cc
…
tmmbr_help.h
Adding NOLINT for typedefs.h and common_types.h
2017-09-15 13:03:51 +00:00
ulpfec_generator_unittest.cc
Delete unneeded includes of basictypes.h.
2018-05-21 19:35:08 +00:00
ulpfec_generator.cc
Delete unneeded includes of basictypes.h.
2018-05-21 19:35:08 +00:00
ulpfec_generator.h
Fix clang style errors in rtp_rtcp and dependant targets
2018-02-07 09:48:28 +00:00
ulpfec_header_reader_writer_unittest.cc
Delete unneeded includes of basictypes.h.
2018-05-21 19:35:08 +00:00
ulpfec_header_reader_writer.cc
…
ulpfec_header_reader_writer.h
Delete unneeded includes of basictypes.h.
2018-05-21 19:35:08 +00:00
ulpfec_receiver_impl.cc
Reformat the WebRTC code base
2018-06-19 14:00:39 +00:00
ulpfec_receiver_impl.h
Fix clang style errors in rtp_rtcp and dependant targets
2018-02-07 09:48:28 +00:00
ulpfec_receiver_unittest.cc
Reformat the WebRTC code base
2018-06-19 14:00:39 +00:00