zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
e16bfde5124fc75dcd294ae1856da820923e18a4
platform-external-webrtc/webrtc/modules/audio_coding/neteq
History
bjornv@webrtc.org 600587d5ac Refactor audio_coding/neteq: Removed usage of macro WEBRTC_SPL_16_16_RSFT 
The macro is defined as
#define WEBRTC_SPL_MUL_16_16_RSFT(a, b, c) \
(WEBRTC_SPL_MUL_16_16(a, b) >> (c))

where the latter macro is in C defined as
#define WEBRTC_SPL_MUL_16_16(a, b) \
    ((int32_t) (((int16_t)(a)) * ((int16_t)(b))))
(For definitions on ARMv7 and MIPS, see common_audio/signal_processing/include/spl_inl_{armv7,mips}.h)

The replacement consists of
- avoiding casts to int16_t if inputs already are int16_t
- adding explicit cast to <type> if result is assigned to <type> (other than int or int32_t)
- minor cleanups like remove of unnecessary parentheses and style changes

In addition an implicit cast from int32_t to int16_t was removed, which was a bug.

BUG=3348, 3353
TESTED=Locally on Mac and trybots
R=henrik.lundin@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/41179004

Cr-Commit-Position: refs/heads/master@{#8653}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8653 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-03-09 13:30:45 +00:00
..
interface
Adding speech_expand_rate to NetEQ Network Statistics.
2015-02-18 10:02:20 +00:00
mock
Reland r8476 "Set decoder output frequency in AudioDecoder::Decode call"
2015-02-25 10:03:19 +00:00
test
Roll chromium_revision e144d30..6fdb142 (318658:318841) + remove OVERRIDE macro
2015-03-04 13:04:54 +00:00
tools
Roll chromium_revision e144d30..6fdb142 (318658:318841) + remove OVERRIDE macro
2015-03-04 13:04:54 +00:00
accelerate.cc
Rename neteq4 folder to neteq
2014-06-09 08:10:28 +00:00
accelerate.h
Roll chromium_revision e144d30..6fdb142 (318658:318841) + remove OVERRIDE macro
2015-03-04 13:04:54 +00:00
audio_classifier_unittest.cc
Use base/scoped_ptr.h; system_wrappers/interface/scoped_ptr.h is going away
2015-02-26 14:43:50 +00:00
audio_classifier.cc
Rename neteq4 folder to neteq
2014-06-09 08:10:28 +00:00
audio_classifier.h
Use base/scoped_ptr.h; system_wrappers/interface/scoped_ptr.h is going away
2015-02-26 14:43:50 +00:00
audio_decoder_impl.cc
Reland r8476 "Set decoder output frequency in AudioDecoder::Decode call"
2015-02-25 10:03:19 +00:00
audio_decoder_impl.h
Roll chromium_revision e144d30..6fdb142 (318658:318841) + remove OVERRIDE macro
2015-03-04 13:04:54 +00:00
audio_decoder_unittest.cc
AudioEncoder: change Encode and EncodeInternal return type to void
2015-02-26 15:38:46 +00:00
audio_decoder_unittests.isolate
Update isolate files for Android APK tests.
2014-11-13 08:35:05 +00:00
audio_multi_vector_unittest.cc
Rename Audio[Multi]Vector.CopyFrom to .CopyTo
2014-09-04 10:58:43 +00:00
audio_multi_vector.cc
Rename Audio[Multi]Vector.CopyFrom to .CopyTo
2014-09-04 10:58:43 +00:00
audio_multi_vector.h
Rename Audio[Multi]Vector.CopyFrom to .CopyTo
2014-09-04 10:58:43 +00:00
audio_vector_unittest.cc
Rename Audio[Multi]Vector.CopyFrom to .CopyTo
2014-09-04 10:58:43 +00:00
audio_vector.cc
Use base/scoped_ptr.h; system_wrappers/interface/scoped_ptr.h is going away
2015-02-26 14:43:50 +00:00
audio_vector.h
Use base/scoped_ptr.h; system_wrappers/interface/scoped_ptr.h is going away
2015-02-26 14:43:50 +00:00
background_noise_unittest.cc
Change gflags and gmock includes to be full paths.
2014-09-04 09:55:40 +00:00
background_noise.cc
Refactor audio_coding/neteq: Removed usage of macro WEBRTC_SPL_16_16_RSFT
2015-03-09 13:30:45 +00:00
background_noise.h
Use base/scoped_ptr.h; system_wrappers/interface/scoped_ptr.h is going away
2015-02-26 14:43:50 +00:00
buffer_level_filter_unittest.cc
Change gflags and gmock includes to be full paths.
2014-09-04 09:55:40 +00:00
buffer_level_filter.cc
Rename neteq4 folder to neteq
2014-06-09 08:10:28 +00:00
buffer_level_filter.h
Rename neteq4 folder to neteq
2014-06-09 08:10:28 +00:00
comfort_noise_unittest.cc
Change gflags and gmock includes to be full paths.
2014-09-04 09:55:40 +00:00
comfort_noise.cc
Move the AudioDecoder interface out of NetEq
2014-12-09 10:12:53 +00:00
comfort_noise.h
Rename neteq4 folder to neteq
2014-06-09 08:10:28 +00:00
decision_logic_fax.cc
Rename neteq4 folder to neteq
2014-06-09 08:10:28 +00:00
decision_logic_fax.h
Roll chromium_revision e144d30..6fdb142 (318658:318841) + remove OVERRIDE macro
2015-03-04 13:04:54 +00:00
decision_logic_normal.cc
Fix problem with late packets in NetEq
2014-11-04 14:03:58 +00:00
decision_logic_normal.h
Rename neteq4 folder to neteq
2014-06-09 08:10:28 +00:00
decision_logic_unittest.cc
Change gflags and gmock includes to be full paths.
2014-09-04 09:55:40 +00:00
decision_logic.cc
Rename neteq4 folder to neteq
2014-06-09 08:10:28 +00:00
decision_logic.h
Rename neteq4 folder to neteq
2014-06-09 08:10:28 +00:00
decoder_database_unittest.cc
Remove the codec_type_ member from AudioDecoder
2014-11-04 11:51:46 +00:00
decoder_database.cc
Misc. cleanup split out of https://webrtc-codereview.appspot.com/37699004/ :
2015-02-23 21:29:45 +00:00
decoder_database.h
Misc. cleanup split out of https://webrtc-codereview.appspot.com/37699004/ :
2015-02-23 21:29:45 +00:00
defines.h
Rename neteq4 folder to neteq
2014-06-09 08:10:28 +00:00
delay_manager_unittest.cc
Change gflags and gmock includes to be full paths.
2014-09-04 09:55:40 +00:00
delay_manager.cc
Rename neteq4 folder to neteq
2014-06-09 08:10:28 +00:00
delay_manager.h
Move the AudioDecoder interface out of NetEq
2014-12-09 10:12:53 +00:00
delay_peak_detector_unittest.cc
Change gflags and gmock includes to be full paths.
2014-09-04 09:55:40 +00:00
delay_peak_detector.cc
Rename neteq4 folder to neteq
2014-06-09 08:10:28 +00:00
delay_peak_detector.h
Rename neteq4 folder to neteq
2014-06-09 08:10:28 +00:00
dsp_helper_unittest.cc
Change gflags and gmock includes to be full paths.
2014-09-04 09:55:40 +00:00
dsp_helper.cc
Rename neteq4 folder to neteq
2014-06-09 08:10:28 +00:00
dsp_helper.h
Rename neteq4 folder to neteq
2014-06-09 08:10:28 +00:00
dtmf_buffer_unittest.cc
Change gflags and gmock includes to be full paths.
2014-09-04 09:55:40 +00:00
dtmf_buffer.cc
Use size_t more consistently for packet/payload lengths.
2014-11-20 22:28:14 +00:00
dtmf_buffer.h
Use size_t more consistently for packet/payload lengths.
2014-11-20 22:28:14 +00:00
dtmf_tone_generator_unittest.cc
Change gflags and gmock includes to be full paths.
2014-09-04 09:55:40 +00:00
dtmf_tone_generator.cc
Add support for multi-channel DTMF tone generation
2014-09-04 07:39:21 +00:00
dtmf_tone_generator.h
Add support for multi-channel DTMF tone generation
2014-09-04 07:39:21 +00:00
expand_unittest.cc
Change gflags and gmock includes to be full paths.
2014-09-04 09:55:40 +00:00
expand.cc
common_audio: Made input signal const in WebRtcSplFilterMAFastQ12()
2015-01-12 05:50:52 +00:00
expand.h
Use base/scoped_ptr.h; system_wrappers/interface/scoped_ptr.h is going away
2015-02-26 14:43:50 +00:00
merge_unittest.cc
Change gflags and gmock includes to be full paths.
2014-09-04 09:55:40 +00:00
merge.cc
Use base/scoped_ptr.h; system_wrappers/interface/scoped_ptr.h is going away
2015-02-26 14:43:50 +00:00
merge.h
Rename neteq4 folder to neteq
2014-06-09 08:10:28 +00:00
neteq_external_decoder_unittest.cc
Roll chromium_revision e144d30..6fdb142 (318658:318841) + remove OVERRIDE macro
2015-03-04 13:04:54 +00:00
neteq_impl_unittest.cc
Reland r8476 "Set decoder output frequency in AudioDecoder::Decode call"
2015-02-25 10:03:19 +00:00
neteq_impl.cc
Reland r8476 "Set decoder output frequency in AudioDecoder::Decode call"
2015-02-25 10:03:19 +00:00
neteq_impl.h
Roll chromium_revision e144d30..6fdb142 (318658:318841) + remove OVERRIDE macro
2015-03-04 13:04:54 +00:00
neteq_network_stats_unittest.cc
Use base/scoped_ptr.h; system_wrappers/interface/scoped_ptr.h is going away
2015-02-26 14:43:50 +00:00
neteq_stereo_unittest.cc
Use base/scoped_ptr.h; system_wrappers/interface/scoped_ptr.h is going away
2015-02-26 14:43:50 +00:00
neteq_tests.gypi
Removing NetEq's direct dependencies on Opus headers.
2015-03-03 09:28:53 +00:00
neteq_unittest.cc
Use base/scoped_ptr.h; system_wrappers/interface/scoped_ptr.h is going away
2015-02-26 14:43:50 +00:00
neteq.cc
Change how background noise mode in NetEq is set
2014-08-07 12:27:37 +00:00
neteq.gypi
Removing NetEq's direct dependencies on Opus headers.
2015-03-03 09:28:53 +00:00
normal_unittest.cc
Use base/scoped_ptr.h; system_wrappers/interface/scoped_ptr.h is going away
2015-02-26 14:43:50 +00:00
normal.cc
Refactor audio_coding/neteq: Removed usage of macro WEBRTC_SPL_16_16_RSFT
2015-03-09 13:30:45 +00:00
normal.h
Rename neteq4 folder to neteq
2014-06-09 08:10:28 +00:00
OWNERS
Add kjellander@webrtc.org as OWNER for *.isolate
2014-06-10 05:42:53 +00:00
packet_buffer_unittest.cc
Fix problem with late packets in NetEq
2014-11-04 14:03:58 +00:00
packet_buffer.cc
Move the AudioDecoder interface out of NetEq
2014-12-09 10:12:53 +00:00
packet_buffer.h
Fix problem with late packets in NetEq
2014-11-04 14:03:58 +00:00
packet.h
Use size_t more consistently for packet/payload lengths.
2014-11-20 22:28:14 +00:00
payload_splitter_unittest.cc
Use base/scoped_ptr.h; system_wrappers/interface/scoped_ptr.h is going away
2015-02-26 14:43:50 +00:00
payload_splitter.cc
Allowing RED decoding for Opus.
2015-02-13 14:02:17 +00:00
payload_splitter.h
Use size_t more consistently for packet/payload lengths.
2014-11-20 22:28:14 +00:00
post_decode_vad_unittest.cc
Change gflags and gmock includes to be full paths.
2014-09-04 09:55:40 +00:00
post_decode_vad.cc
Rename neteq4 folder to neteq
2014-06-09 08:10:28 +00:00
post_decode_vad.h
Move the AudioDecoder interface out of NetEq
2014-12-09 10:12:53 +00:00
preemptive_expand.cc
Rename neteq4 folder to neteq
2014-06-09 08:10:28 +00:00
preemptive_expand.h
Rename neteq4 folder to neteq
2014-06-09 08:10:28 +00:00
random_vector_unittest.cc
Change gflags and gmock includes to be full paths.
2014-09-04 09:55:40 +00:00
random_vector.cc
Rename neteq4 folder to neteq
2014-06-09 08:10:28 +00:00
random_vector.h
Rename neteq4 folder to neteq
2014-06-09 08:10:28 +00:00
rtcp.cc
Rename neteq4 folder to neteq
2014-06-09 08:10:28 +00:00
rtcp.h
Rename neteq4 folder to neteq
2014-06-09 08:10:28 +00:00
statistics_calculator.cc
Adding speech_expand_rate to NetEQ Network Statistics.
2015-02-18 10:02:20 +00:00
statistics_calculator.h
Adding speech_expand_rate to NetEQ Network Statistics.
2015-02-18 10:02:20 +00:00
sync_buffer_unittest.cc
Change gflags and gmock includes to be full paths.
2014-09-04 09:55:40 +00:00
sync_buffer.cc
Rename neteq4 folder to neteq
2014-06-09 08:10:28 +00:00
sync_buffer.h
Rename neteq4 folder to neteq
2014-06-09 08:10:28 +00:00
time_stretch_unittest.cc
Change gflags and gmock includes to be full paths.
2014-09-04 09:55:40 +00:00
time_stretch.cc
Use base/scoped_ptr.h; system_wrappers/interface/scoped_ptr.h is going away
2015-02-26 14:43:50 +00:00
time_stretch.h
Rename neteq4 folder to neteq
2014-06-09 08:10:28 +00:00
timestamp_scaler_unittest.cc
Change gflags and gmock includes to be full paths.
2014-09-04 09:55:40 +00:00
timestamp_scaler.cc
Enable Clang warning implicit-fallthrough and annotate the code.
2015-01-28 18:38:13 +00:00
timestamp_scaler.h
Rename neteq4 folder to neteq
2014-06-09 08:10:28 +00:00