e2a284d299
Metrics are added to measure: 1. The number of send encodings in calls to AddTransceiver. 2. The number of times that simulcast is disabled because there is no support from remote peer. 3. The number of times simulcast is indicated in ApplyLocal and ApplyRemote and with which API surface (no simulcast, legacy munging, spec-compliant). Bug: webrtc:10372 Change-Id: I84717a1911efdf8aaf43cd6c04c7f09fcf2c58f0 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/125482 Commit-Queue: Amit Hilbuch <amithi@webrtc.org> Reviewed-by: Steve Anton <steveanton@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26979}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.