e34d62caec
This reverts commit c36c8e114df8f21ec286adf1ffe76cf5fc495f53. Reason for revert: Breaks downstream code. Original change's description: > Makes send side network estimation opt-in. > > Bug: webrtc:10742 > Change-Id: I57159a3bf853ef8de32f5ba70ad4fa897ee5c528 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/144046 > Reviewed-by: Björn Terelius <terelius@webrtc.org> > Commit-Queue: Sebastian Jansson <srte@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#28631} TBR=terelius@webrtc.org,srte@webrtc.org Change-Id: Ie9ce099d9154551fd123dbc1eca96ca2730fbc9f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:10742 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/146544 Reviewed-by: Sebastian Jansson <srte@webrtc.org> Commit-Queue: Sebastian Jansson <srte@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28634}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.