e448a3fb54
Call DataChannelObserver::OnBufferedAmountChange on each successful send. Previously, the observer would get notified of buffered amount changes only when queued send data is consumed. Data gets queued only if it cannot be sent right away. According to the WebRTC standard[1], bufferedamount should be increased before each sent and decreased after each successful sent. Update implementation to be standard compliant. Design doc: http://doc/1lorHBn-GMn5U0T0RQANxrsW0pXhw8XGZM-xZyVUOW90 [1] https://w3c.github.io/webrtc-pc/#dom-datachannel-bufferedamount Bug: chromium:878682 Change-Id: Ife009d30c4a18dced9a54cf600a445bb1f02561d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/123237 Commit-Queue: Marina Ciocea <marinaciocea@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Henrik Boström <hbos@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27057}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.