e6f3897945
This reverts commit 94fe0d3de5e8162d1a105fd1a3ec4bd2da97f43b. Reason for revert: Causes an assert in this line during a call: https://source.chromium.org/chromium/chromium/src/+/master:third_party/webrtc/sdk/objc/api/peerconnection/RTCStatisticsReport.mm;drc=87a6e5ab4d8f0baf4e2a9b7752b43d825f9c0ce1;l=122?originalUrl=https:%2F%2Fcs.chromium.org%2F where frameWidth appears more than once Original change's description: > Complete migration from "track" to "inbound-rtp" stats > > Bug: webrtc:11683 > Change-Id: I4c4a4fa0a7d6a20976922aca41d57540aa27fd1d > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178611 > Reviewed-by: Henrik Boström <hbos@webrtc.org> > Reviewed-by: Harald Alvestrand <hta@webrtc.org> > Commit-Queue: Eldar Rello <elrello@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#31683} TBR=hbos@webrtc.org,hta@webrtc.org,elrello@microsoft.com Change-Id: I0ded36a40c8808dac5a777ed41815e52ab9a2573 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:11683 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/179020 Reviewed-by: Zeke Chin <tkchin@webrtc.org> Commit-Queue: Zeke Chin <tkchin@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31692}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.