ebe5acb27a
Adds ability to specify desired frame size separate from actual clip resolution, as well as clip and desired fps. This allows e.g. reading an HD clip but running benchmarks in VGA, and to specify e.g. 60fps for the clip but 30for encoding where frame dropping kicks in so that motion is actually correct rather than just plaing the clip slowly. Bug: webrtc:12229 Change-Id: I4ad4fcc335611a449dc2723ffafbec6731e89f55 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/195324 Commit-Queue: Erik Språng <sprang@webrtc.org> Reviewed-by: Philip Eliasson <philipel@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32839}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.