
Reland with fixes. Currently some video frames metadata like rotation or ntp timestamps are copied in every encoder and decoder separately. This CL makes copying to happen at a single place for send or receive side. This will make it easier to add new metadata in the future. Also, added some missing tests. Original Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133346 Bug: webrtc:10460 Change-Id: I98629589fa55ca1d74056033cf86faccfdf848cd Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/136582 Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Reviewed-by: Niels Moller <nisse@webrtc.org> Reviewed-by: Erik Språng <sprang@webrtc.org> Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27930}
313 lines
12 KiB
C++
313 lines
12 KiB
C++
/*
|
|
* Copyright 2017 The WebRTC Project Authors. All rights reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#include <utility>
|
|
#include <vector>
|
|
|
|
#include "test/gmock.h"
|
|
#include "test/gtest.h"
|
|
|
|
#include "absl/memory/memory.h"
|
|
#include "api/task_queue/default_task_queue_factory.h"
|
|
#include "api/test/video/function_video_decoder_factory.h"
|
|
#include "api/video_codecs/video_decoder.h"
|
|
#include "call/rtp_stream_receiver_controller.h"
|
|
#include "common_video/test/utilities.h"
|
|
#include "media/base/fake_video_renderer.h"
|
|
#include "modules/pacing/packet_router.h"
|
|
#include "modules/rtp_rtcp/source/rtp_packet_to_send.h"
|
|
#include "modules/utility/include/process_thread.h"
|
|
#include "rtc_base/critical_section.h"
|
|
#include "rtc_base/event.h"
|
|
#include "system_wrappers/include/clock.h"
|
|
#include "test/fake_decoder.h"
|
|
#include "test/field_trial.h"
|
|
#include "test/video_decoder_proxy_factory.h"
|
|
#include "video/call_stats.h"
|
|
#include "video/video_receive_stream.h"
|
|
|
|
namespace webrtc {
|
|
namespace {
|
|
|
|
using ::testing::_;
|
|
using ::testing::Invoke;
|
|
|
|
constexpr int kDefaultTimeOutMs = 50;
|
|
|
|
class MockTransport : public Transport {
|
|
public:
|
|
MOCK_METHOD3(SendRtp,
|
|
bool(const uint8_t* packet,
|
|
size_t length,
|
|
const PacketOptions& options));
|
|
MOCK_METHOD2(SendRtcp, bool(const uint8_t* packet, size_t length));
|
|
};
|
|
|
|
class MockVideoDecoder : public VideoDecoder {
|
|
public:
|
|
MOCK_METHOD2(InitDecode,
|
|
int32_t(const VideoCodec* config, int32_t number_of_cores));
|
|
MOCK_METHOD3(Decode,
|
|
int32_t(const EncodedImage& input,
|
|
bool missing_frames,
|
|
int64_t render_time_ms));
|
|
MOCK_METHOD1(RegisterDecodeCompleteCallback,
|
|
int32_t(DecodedImageCallback* callback));
|
|
MOCK_METHOD0(Release, int32_t(void));
|
|
const char* ImplementationName() const { return "MockVideoDecoder"; }
|
|
};
|
|
|
|
class FrameObjectFake : public video_coding::EncodedFrame {
|
|
public:
|
|
void SetPayloadType(uint8_t payload_type) { _payloadType = payload_type; }
|
|
|
|
void SetRotation(const VideoRotation& rotation) { rotation_ = rotation; }
|
|
|
|
void SetNtpTime(int64_t ntp_time_ms) { ntp_time_ms_ = ntp_time_ms; }
|
|
|
|
int64_t ReceivedTime() const override { return 0; }
|
|
|
|
int64_t RenderTime() const override { return _renderTimeMs; }
|
|
};
|
|
|
|
} // namespace
|
|
|
|
class VideoReceiveStreamTest : public ::testing::Test {
|
|
public:
|
|
VideoReceiveStreamTest()
|
|
: process_thread_(ProcessThread::Create("TestThread")),
|
|
task_queue_factory_(CreateDefaultTaskQueueFactory()),
|
|
config_(&mock_transport_),
|
|
call_stats_(Clock::GetRealTimeClock(), process_thread_.get()),
|
|
h264_decoder_factory_(&mock_h264_video_decoder_),
|
|
null_decoder_factory_(&mock_null_video_decoder_) {}
|
|
|
|
void SetUp() {
|
|
constexpr int kDefaultNumCpuCores = 2;
|
|
config_.rtp.remote_ssrc = 1111;
|
|
config_.rtp.local_ssrc = 2222;
|
|
config_.renderer = &fake_renderer_;
|
|
VideoReceiveStream::Decoder h264_decoder;
|
|
h264_decoder.payload_type = 99;
|
|
h264_decoder.video_format = SdpVideoFormat("H264");
|
|
h264_decoder.video_format.parameters.insert(
|
|
{"sprop-parameter-sets", "Z0IACpZTBYmI,aMljiA=="});
|
|
h264_decoder.decoder_factory = &h264_decoder_factory_;
|
|
config_.decoders.push_back(h264_decoder);
|
|
VideoReceiveStream::Decoder null_decoder;
|
|
null_decoder.payload_type = 98;
|
|
null_decoder.video_format = SdpVideoFormat("null");
|
|
null_decoder.decoder_factory = &null_decoder_factory_;
|
|
config_.decoders.push_back(null_decoder);
|
|
|
|
Clock* clock = Clock::GetRealTimeClock();
|
|
timing_ = new VCMTiming(clock);
|
|
|
|
video_receive_stream_ =
|
|
absl::make_unique<webrtc::internal::VideoReceiveStream>(
|
|
task_queue_factory_.get(), &rtp_stream_receiver_controller_,
|
|
kDefaultNumCpuCores, &packet_router_, config_.Copy(),
|
|
process_thread_.get(), &call_stats_, clock, timing_);
|
|
}
|
|
|
|
protected:
|
|
std::unique_ptr<ProcessThread> process_thread_;
|
|
const std::unique_ptr<TaskQueueFactory> task_queue_factory_;
|
|
VideoReceiveStream::Config config_;
|
|
CallStats call_stats_;
|
|
MockVideoDecoder mock_h264_video_decoder_;
|
|
MockVideoDecoder mock_null_video_decoder_;
|
|
test::VideoDecoderProxyFactory h264_decoder_factory_;
|
|
test::VideoDecoderProxyFactory null_decoder_factory_;
|
|
cricket::FakeVideoRenderer fake_renderer_;
|
|
MockTransport mock_transport_;
|
|
PacketRouter packet_router_;
|
|
RtpStreamReceiverController rtp_stream_receiver_controller_;
|
|
std::unique_ptr<webrtc::internal::VideoReceiveStream> video_receive_stream_;
|
|
VCMTiming* timing_;
|
|
};
|
|
|
|
TEST_F(VideoReceiveStreamTest, CreateFrameFromH264FmtpSpropAndIdr) {
|
|
constexpr uint8_t idr_nalu[] = {0x05, 0xFF, 0xFF, 0xFF};
|
|
RtpPacketToSend rtppacket(nullptr);
|
|
uint8_t* payload = rtppacket.AllocatePayload(sizeof(idr_nalu));
|
|
memcpy(payload, idr_nalu, sizeof(idr_nalu));
|
|
rtppacket.SetMarker(true);
|
|
rtppacket.SetSsrc(1111);
|
|
rtppacket.SetPayloadType(99);
|
|
rtppacket.SetSequenceNumber(1);
|
|
rtppacket.SetTimestamp(0);
|
|
rtc::Event init_decode_event_;
|
|
EXPECT_CALL(mock_h264_video_decoder_, InitDecode(_, _))
|
|
.WillOnce(Invoke([&init_decode_event_](const VideoCodec* config,
|
|
int32_t number_of_cores) {
|
|
init_decode_event_.Set();
|
|
return 0;
|
|
}));
|
|
EXPECT_CALL(mock_h264_video_decoder_, RegisterDecodeCompleteCallback(_));
|
|
video_receive_stream_->Start();
|
|
EXPECT_CALL(mock_h264_video_decoder_, Decode(_, false, _));
|
|
RtpPacketReceived parsed_packet;
|
|
ASSERT_TRUE(parsed_packet.Parse(rtppacket.data(), rtppacket.size()));
|
|
rtp_stream_receiver_controller_.OnRtpPacket(parsed_packet);
|
|
EXPECT_CALL(mock_h264_video_decoder_, Release());
|
|
// Make sure the decoder thread had a chance to run.
|
|
init_decode_event_.Wait(kDefaultTimeOutMs);
|
|
}
|
|
|
|
TEST_F(VideoReceiveStreamTest, PlayoutDelay) {
|
|
const PlayoutDelay kPlayoutDelayMs = {123, 321};
|
|
std::unique_ptr<FrameObjectFake> test_frame(new FrameObjectFake());
|
|
test_frame->id.picture_id = 0;
|
|
test_frame->SetPlayoutDelay(kPlayoutDelayMs);
|
|
|
|
video_receive_stream_->OnCompleteFrame(std::move(test_frame));
|
|
EXPECT_EQ(kPlayoutDelayMs.min_ms, timing_->min_playout_delay());
|
|
EXPECT_EQ(kPlayoutDelayMs.max_ms, timing_->max_playout_delay());
|
|
|
|
// Check that the biggest minimum delay is chosen.
|
|
video_receive_stream_->SetMinimumPlayoutDelay(400);
|
|
EXPECT_EQ(400, timing_->min_playout_delay());
|
|
|
|
// Check base minimum delay validation.
|
|
EXPECT_FALSE(video_receive_stream_->SetBaseMinimumPlayoutDelayMs(12345));
|
|
EXPECT_FALSE(video_receive_stream_->SetBaseMinimumPlayoutDelayMs(-1));
|
|
EXPECT_TRUE(video_receive_stream_->SetBaseMinimumPlayoutDelayMs(500));
|
|
EXPECT_EQ(500, timing_->min_playout_delay());
|
|
|
|
// Check that intermidiate values are remembered and the biggest remembered
|
|
// is chosen.
|
|
video_receive_stream_->SetBaseMinimumPlayoutDelayMs(0);
|
|
EXPECT_EQ(400, timing_->min_playout_delay());
|
|
|
|
video_receive_stream_->SetMinimumPlayoutDelay(0);
|
|
EXPECT_EQ(123, timing_->min_playout_delay());
|
|
}
|
|
|
|
TEST_F(VideoReceiveStreamTest, PlayoutDelayPreservesDefaultMaxValue) {
|
|
const int default_max_playout_latency = timing_->max_playout_delay();
|
|
const PlayoutDelay kPlayoutDelayMs = {123, -1};
|
|
|
|
std::unique_ptr<FrameObjectFake> test_frame(new FrameObjectFake());
|
|
test_frame->id.picture_id = 0;
|
|
test_frame->SetPlayoutDelay(kPlayoutDelayMs);
|
|
|
|
video_receive_stream_->OnCompleteFrame(std::move(test_frame));
|
|
|
|
// Ensure that -1 preserves default maximum value from |timing_|.
|
|
EXPECT_EQ(kPlayoutDelayMs.min_ms, timing_->min_playout_delay());
|
|
EXPECT_NE(kPlayoutDelayMs.max_ms, timing_->max_playout_delay());
|
|
EXPECT_EQ(default_max_playout_latency, timing_->max_playout_delay());
|
|
}
|
|
|
|
TEST_F(VideoReceiveStreamTest, PlayoutDelayPreservesDefaultMinValue) {
|
|
const int default_min_playout_latency = timing_->min_playout_delay();
|
|
const PlayoutDelay kPlayoutDelayMs = {-1, 321};
|
|
|
|
std::unique_ptr<FrameObjectFake> test_frame(new FrameObjectFake());
|
|
test_frame->id.picture_id = 0;
|
|
test_frame->SetPlayoutDelay(kPlayoutDelayMs);
|
|
|
|
video_receive_stream_->OnCompleteFrame(std::move(test_frame));
|
|
|
|
// Ensure that -1 preserves default minimum value from |timing_|.
|
|
EXPECT_NE(kPlayoutDelayMs.min_ms, timing_->min_playout_delay());
|
|
EXPECT_EQ(kPlayoutDelayMs.max_ms, timing_->max_playout_delay());
|
|
EXPECT_EQ(default_min_playout_latency, timing_->min_playout_delay());
|
|
}
|
|
|
|
class VideoReceiveStreamTestWithFakeDecoder : public ::testing::Test {
|
|
public:
|
|
VideoReceiveStreamTestWithFakeDecoder()
|
|
: fake_decoder_factory_(
|
|
[]() { return absl::make_unique<test::FakeDecoder>(); }),
|
|
process_thread_(ProcessThread::Create("TestThread")),
|
|
task_queue_factory_(CreateDefaultTaskQueueFactory()),
|
|
config_(&mock_transport_),
|
|
call_stats_(Clock::GetRealTimeClock(), process_thread_.get()) {}
|
|
|
|
void SetUp() {
|
|
constexpr int kDefaultNumCpuCores = 2;
|
|
config_.rtp.remote_ssrc = 1111;
|
|
config_.rtp.local_ssrc = 2222;
|
|
config_.renderer = &fake_renderer_;
|
|
VideoReceiveStream::Decoder fake_decoder;
|
|
fake_decoder.payload_type = 99;
|
|
fake_decoder.video_format = SdpVideoFormat("VP8");
|
|
fake_decoder.decoder_factory = &fake_decoder_factory_;
|
|
config_.decoders.push_back(fake_decoder);
|
|
Clock* clock = Clock::GetRealTimeClock();
|
|
timing_ = new VCMTiming(clock);
|
|
|
|
video_receive_stream_.reset(new webrtc::internal::VideoReceiveStream(
|
|
task_queue_factory_.get(), &rtp_stream_receiver_controller_,
|
|
kDefaultNumCpuCores, &packet_router_, config_.Copy(),
|
|
process_thread_.get(), &call_stats_, clock, timing_));
|
|
}
|
|
|
|
protected:
|
|
test::FunctionVideoDecoderFactory fake_decoder_factory_;
|
|
std::unique_ptr<ProcessThread> process_thread_;
|
|
const std::unique_ptr<TaskQueueFactory> task_queue_factory_;
|
|
VideoReceiveStream::Config config_;
|
|
CallStats call_stats_;
|
|
cricket::FakeVideoRenderer fake_renderer_;
|
|
MockTransport mock_transport_;
|
|
PacketRouter packet_router_;
|
|
RtpStreamReceiverController rtp_stream_receiver_controller_;
|
|
std::unique_ptr<webrtc::internal::VideoReceiveStream> video_receive_stream_;
|
|
VCMTiming* timing_;
|
|
};
|
|
|
|
TEST_F(VideoReceiveStreamTestWithFakeDecoder, PassesNtpTime) {
|
|
const int64_t kNtpTimestamp = 12345;
|
|
auto test_frame = absl::make_unique<FrameObjectFake>();
|
|
test_frame->SetPayloadType(99);
|
|
test_frame->id.picture_id = 0;
|
|
test_frame->SetNtpTime(kNtpTimestamp);
|
|
|
|
video_receive_stream_->Start();
|
|
video_receive_stream_->OnCompleteFrame(std::move(test_frame));
|
|
EXPECT_TRUE(fake_renderer_.WaitForRenderedFrame(kDefaultTimeOutMs));
|
|
EXPECT_EQ(kNtpTimestamp, fake_renderer_.ntp_time_ms());
|
|
}
|
|
|
|
TEST_F(VideoReceiveStreamTestWithFakeDecoder, PassesRotation) {
|
|
const webrtc::VideoRotation kRotation = webrtc::kVideoRotation_180;
|
|
auto test_frame = absl::make_unique<FrameObjectFake>();
|
|
test_frame->SetPayloadType(99);
|
|
test_frame->id.picture_id = 0;
|
|
test_frame->SetRotation(kRotation);
|
|
|
|
video_receive_stream_->Start();
|
|
video_receive_stream_->OnCompleteFrame(std::move(test_frame));
|
|
EXPECT_TRUE(fake_renderer_.WaitForRenderedFrame(kDefaultTimeOutMs));
|
|
|
|
EXPECT_EQ(kRotation, fake_renderer_.rotation());
|
|
}
|
|
|
|
TEST_F(VideoReceiveStreamTestWithFakeDecoder, PassesColorSpace) {
|
|
auto test_frame = absl::make_unique<FrameObjectFake>();
|
|
test_frame->SetPayloadType(99);
|
|
test_frame->id.picture_id = 0;
|
|
webrtc::ColorSpace color_space =
|
|
CreateTestColorSpace(/*with_hdr_metadata=*/true);
|
|
test_frame->SetColorSpace(color_space);
|
|
|
|
video_receive_stream_->Start();
|
|
video_receive_stream_->OnCompleteFrame(std::move(test_frame));
|
|
EXPECT_TRUE(fake_renderer_.WaitForRenderedFrame(kDefaultTimeOutMs));
|
|
|
|
ASSERT_TRUE(fake_renderer_.color_space().has_value());
|
|
EXPECT_EQ(color_space, *fake_renderer_.color_space());
|
|
}
|
|
|
|
} // namespace webrtc
|