ef0627fb50
This reverts commit fbde32e596f06893d6dda13eb7d29f4c251cf08b. Reason for revert: It seems to break WebRTC FYI tests in Chromium. https://ci.chromium.org/p/chromium/builders/webrtc.fyi/WebRTC%20Chromium%20FYI%20Linux%20Tester/4763 Original change's description: > Fix GetStats bytesSent/Received, wireup headerBytesSent/Received > > Changes the standard GetStats, legacy GetStats unchanged. > > Bug: webrtc:10525 > Change-Id: Ie10fe8079f1d8b4cc6bbe513f6a2fc91477b5441 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/156084 > Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> > Reviewed-by: Henrik Boström <hbos@webrtc.org> > Reviewed-by: Harald Alvestrand <hta@webrtc.org> > Commit-Queue: Niels Moller <nisse@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#29462} TBR=kwiberg@webrtc.org,hbos@webrtc.org,nisse@webrtc.org,hta@webrtc.org Change-Id: I6a983ea4d5ff38e49f096a8ff5cd9b426768f955 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:10525 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157043 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29478}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.