41f16bec9f
The unit tests for AudioSendStream was generating a lot of warnings about "Uninteresting mock function call" on mocked objects. This is due to the default gmock implementation being NaggyMock and there was no NiceMock override. With this change the mocks are replaced with NiceMock implementations which do not output warnings for unexpected calls. This makes the error output from the test runner much easier to visually parse to find the actual errors in failing tests. Bug: None Change-Id: Ic40db78159536ddeaa72a468fc2cb3ec17386d44 Reviewed-on: https://webrtc-review.googlesource.com/56220 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Sebastian Jansson <srte@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22152}
93 lines
3.5 KiB
C++
93 lines
3.5 KiB
C++
/*
|
|
* Copyright (c) 2017 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#ifndef TEST_MOCK_AUDIO_ENCODER_FACTORY_H_
|
|
#define TEST_MOCK_AUDIO_ENCODER_FACTORY_H_
|
|
|
|
#include <memory>
|
|
#include <vector>
|
|
|
|
#include "api/audio_codecs/audio_encoder_factory.h"
|
|
#include "rtc_base/refcountedobject.h"
|
|
#include "rtc_base/scoped_ref_ptr.h"
|
|
#include "test/gmock.h"
|
|
|
|
namespace webrtc {
|
|
|
|
class MockAudioEncoderFactory : public testing::NiceMock<AudioEncoderFactory> {
|
|
public:
|
|
MOCK_METHOD0(GetSupportedEncoders, std::vector<AudioCodecSpec>());
|
|
MOCK_METHOD1(QueryAudioEncoder,
|
|
rtc::Optional<AudioCodecInfo>(const SdpAudioFormat& format));
|
|
|
|
std::unique_ptr<AudioEncoder> MakeAudioEncoder(int payload_type,
|
|
const SdpAudioFormat& format) {
|
|
std::unique_ptr<AudioEncoder> return_value;
|
|
MakeAudioEncoderMock(payload_type, format, &return_value);
|
|
return return_value;
|
|
}
|
|
MOCK_METHOD3(MakeAudioEncoderMock,
|
|
void(int payload_type,
|
|
const SdpAudioFormat& format,
|
|
std::unique_ptr<AudioEncoder>* return_value));
|
|
|
|
// Creates a MockAudioEncoderFactory with no formats and that may not be
|
|
// invoked to create a codec - useful for initializing a voice engine, for
|
|
// example.
|
|
static rtc::scoped_refptr<webrtc::MockAudioEncoderFactory>
|
|
CreateUnusedFactory() {
|
|
using testing::_;
|
|
using testing::AnyNumber;
|
|
using testing::Return;
|
|
|
|
rtc::scoped_refptr<webrtc::MockAudioEncoderFactory> factory =
|
|
new rtc::RefCountedObject<webrtc::MockAudioEncoderFactory>;
|
|
ON_CALL(*factory.get(), GetSupportedEncoders())
|
|
.WillByDefault(Return(std::vector<webrtc::AudioCodecSpec>()));
|
|
ON_CALL(*factory.get(), QueryAudioEncoder(_))
|
|
.WillByDefault(Return(rtc::nullopt));
|
|
|
|
EXPECT_CALL(*factory.get(), GetSupportedEncoders()).Times(AnyNumber());
|
|
EXPECT_CALL(*factory.get(), QueryAudioEncoder(_)).Times(AnyNumber());
|
|
EXPECT_CALL(*factory.get(), MakeAudioEncoderMock(_, _, _)).Times(0);
|
|
return factory;
|
|
}
|
|
|
|
// Creates a MockAudioEncoderFactory with no formats that may be invoked to
|
|
// create a codec any number of times. It will, though, return nullptr on each
|
|
// call, since it supports no codecs.
|
|
static rtc::scoped_refptr<webrtc::MockAudioEncoderFactory>
|
|
CreateEmptyFactory() {
|
|
using testing::_;
|
|
using testing::AnyNumber;
|
|
using testing::Return;
|
|
using testing::SetArgPointee;
|
|
|
|
rtc::scoped_refptr<webrtc::MockAudioEncoderFactory> factory =
|
|
new rtc::RefCountedObject<webrtc::MockAudioEncoderFactory>;
|
|
ON_CALL(*factory.get(), GetSupportedEncoders())
|
|
.WillByDefault(Return(std::vector<webrtc::AudioCodecSpec>()));
|
|
ON_CALL(*factory.get(), QueryAudioEncoder(_))
|
|
.WillByDefault(Return(rtc::nullopt));
|
|
ON_CALL(*factory.get(), MakeAudioEncoderMock(_, _, _))
|
|
.WillByDefault(SetArgPointee<2>(nullptr));
|
|
|
|
EXPECT_CALL(*factory.get(), GetSupportedEncoders()).Times(AnyNumber());
|
|
EXPECT_CALL(*factory.get(), QueryAudioEncoder(_)).Times(AnyNumber());
|
|
EXPECT_CALL(*factory.get(), MakeAudioEncoderMock(_, _, _))
|
|
.Times(AnyNumber());
|
|
return factory;
|
|
}
|
|
};
|
|
|
|
} // namespace webrtc
|
|
|
|
#endif // TEST_MOCK_AUDIO_ENCODER_FACTORY_H_
|