f4e0c29ed1
This CL adds an optional second encoder factory to SimulcastEncoderAdapter, that can be used to create software fallback adapter per simulcast layer. It also adds logic to check if the encoder supports simulcast natively, if so it only allocates a single instance and delegates the simulcast logic to that encoder instead. This means we will be able to remove EncoderSimulcastProxy. Bug: webrtc:11000 Change-Id: Ifd5f029cc281ee2cedf9d18efa5e7e460884d6ff Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/155171 Commit-Queue: Erik Språng <sprang@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29364}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.