df625f46c0
This reverts commit 2b9fa09fa3e3379fd8e76490c394f25670352ef2. Reason for revert: speculative revert since it seems to break Chrome FYI bots. See https://ci.chromium.org/p/chromium/builders/webrtc.fyi/WebRTC%20Chromium%20FYI%20Linux%20Tester/4206 Original change's description: > [GetStats] Expose video codec implementation in standardized metrics. > > Spec issue: https://github.com/w3c/webrtc-stats/issues/445 > Spec PR: https://github.com/w3c/webrtc-stats/pull/473 > > Now that the spec's RTCCodecStats.implementation has moved to > RTCOutboundRtpStreamStats.encoderImplementation and > RTCInboundRtpStreamStats.decoderImplementation, this CL implements them > using the same string that the legacy getStats() API used. > > Bug: webrtc:10890 > Change-Id: Ic43ce44735453626791959df3061ee253356015a > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/149168 > Commit-Queue: Henrik Boström <hbos@webrtc.org> > Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#28877} TBR=ilnik@webrtc.org,hbos@webrtc.org Change-Id: Ia0b7f9806564cf28881c50d6371b8141a22e3431 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:10890 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/149175 Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Henrik Andreassson <henrika@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28879}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.