90edc65929
Adding a some checks and switching out a few assert for RTC_[D]CHECK.
These changes are around use of AudioFrame.data_ to help us catch issues earlier since assert() is left out in release builds, including builds with DCHECK enabled. I've also added a few full-on CHECKs to avoid reading past buffer boundaries or continuing on in a failed state.
TBR=kjellander@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Committed: https://crrev.com/60c4e0ae8f124f08372645a95042f4a1246d7aa3
Cr-Commit-Position: refs/heads/master@{#12925}
Committed: https://crrev.com/5771beb265129082d31736259b7dc6ca037cff4d
Cr-Commit-Position: refs/heads/master@{#12926}
Committed: https://crrev.com/54e1c6a500e390e543bce7b78fae65eb9bb14ab6
Cr-Commit-Position: refs/heads/master@{#12927}
Committed: https://crrev.com/f9d2fe983fe196373850c55acd3dc3824add480e
Cr-Commit-Position: refs/heads/master@{#12928}
Committed: f4fc0ff6f9
Committed: https://crrev.com/c47f0099eee08e8b6731a359563ba09dfe453ded
Cr-Commit-Position: refs/heads/master@{#12930}
Committed: https://crrev.com/0ad72ead67ce848b45541af6aba0a15486b5e0a7
Cr-Commit-Position: refs/heads/master@{#12931}
Review URL: https://codereview.webrtc.org/2014973002 .
Cr-Commit-Position: refs/heads/master@{#12933}
56 lines
2.0 KiB
C++
56 lines
2.0 KiB
C++
/*
|
|
* Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#include "testing/gtest/include/gtest/gtest.h"
|
|
#include "webrtc/base/checks.h" // force defintion of RTC_DCHECK_IS_ON
|
|
#include "webrtc/common_audio/resampler/include/push_resampler.h"
|
|
|
|
// Quality testing of PushResampler is handled through output_mixer_unittest.cc.
|
|
|
|
namespace webrtc {
|
|
|
|
// The below tests are temporarily disabled on WEBRTC_WIN due to problems
|
|
// with clang debug builds.
|
|
// TODO(tommi): Re-enable when we've figured out what the problem is.
|
|
// http://crbug.com/615050
|
|
#if !defined(WEBRTC_WIN) && defined(__clang__) && !defined(NDEBUG)
|
|
TEST(PushResamplerTest, VerifiesInputParameters) {
|
|
PushResampler<int16_t> resampler;
|
|
EXPECT_EQ(0, resampler.InitializeIfNeeded(16000, 16000, 1));
|
|
EXPECT_EQ(0, resampler.InitializeIfNeeded(16000, 16000, 2));
|
|
}
|
|
|
|
#if RTC_DCHECK_IS_ON && GTEST_HAS_DEATH_TEST && !defined(WEBRTC_ANDROID)
|
|
TEST(PushResamplerTest, VerifiesBadInputParameters1) {
|
|
PushResampler<int16_t> resampler;
|
|
EXPECT_DEATH(resampler.InitializeIfNeeded(-1, 16000, 1),
|
|
"src_sample_rate_hz");
|
|
}
|
|
|
|
TEST(PushResamplerTest, VerifiesBadInputParameters2) {
|
|
PushResampler<int16_t> resampler;
|
|
EXPECT_DEATH(resampler.InitializeIfNeeded(16000, -1, 1),
|
|
"dst_sample_rate_hz");
|
|
}
|
|
|
|
TEST(PushResamplerTest, VerifiesBadInputParameters3) {
|
|
PushResampler<int16_t> resampler;
|
|
EXPECT_DEATH(resampler.InitializeIfNeeded(16000, 16000, 0), "num_channels");
|
|
}
|
|
|
|
TEST(PushResamplerTest, VerifiesBadInputParameters4) {
|
|
PushResampler<int16_t> resampler;
|
|
EXPECT_DEATH(resampler.InitializeIfNeeded(16000, 16000, 3), "num_channels");
|
|
}
|
|
#endif
|
|
#endif
|
|
|
|
} // namespace webrtc
|