3e70781361
This is a follow-up to https://webrtc-review.googlesource.com/c/src/+/106280. This time the whole code base is covered. Some files may have not been fixed though, whenever the IWYU tool was breaking the build. Bug: webrtc:8311 Change-Id: I2c31f552a87e887d33931d46e87b6208b1e483ef Reviewed-on: https://webrtc-review.googlesource.com/c/111965 Commit-Queue: Yves Gerey <yvesg@google.com> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25830}
78 lines
2.6 KiB
C++
78 lines
2.6 KiB
C++
/*
|
|
* Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#include <stdint.h>
|
|
#include <string.h>
|
|
|
|
#include "api/video/i420_buffer.h"
|
|
#include "api/video/video_frame_buffer.h"
|
|
#include "common_video/include/i420_buffer_pool.h"
|
|
#include "rtc_base/scoped_ref_ptr.h"
|
|
#include "test/gtest.h"
|
|
|
|
namespace webrtc {
|
|
|
|
TEST(TestI420BufferPool, SimpleFrameReuse) {
|
|
I420BufferPool pool;
|
|
rtc::scoped_refptr<I420BufferInterface> buffer = pool.CreateBuffer(16, 16);
|
|
EXPECT_EQ(16, buffer->width());
|
|
EXPECT_EQ(16, buffer->height());
|
|
// Extract non-refcounted pointers for testing.
|
|
const uint8_t* y_ptr = buffer->DataY();
|
|
const uint8_t* u_ptr = buffer->DataU();
|
|
const uint8_t* v_ptr = buffer->DataV();
|
|
// Release buffer so that it is returned to the pool.
|
|
buffer = nullptr;
|
|
// Check that the memory is resued.
|
|
buffer = pool.CreateBuffer(16, 16);
|
|
EXPECT_EQ(y_ptr, buffer->DataY());
|
|
EXPECT_EQ(u_ptr, buffer->DataU());
|
|
EXPECT_EQ(v_ptr, buffer->DataV());
|
|
EXPECT_EQ(16, buffer->width());
|
|
EXPECT_EQ(16, buffer->height());
|
|
}
|
|
|
|
TEST(TestI420BufferPool, FailToReuse) {
|
|
I420BufferPool pool;
|
|
rtc::scoped_refptr<I420BufferInterface> buffer = pool.CreateBuffer(16, 16);
|
|
// Extract non-refcounted pointers for testing.
|
|
const uint8_t* u_ptr = buffer->DataU();
|
|
const uint8_t* v_ptr = buffer->DataV();
|
|
// Release buffer so that it is returned to the pool.
|
|
buffer = nullptr;
|
|
// Check that the pool doesn't try to reuse buffers of incorrect size.
|
|
buffer = pool.CreateBuffer(32, 16);
|
|
EXPECT_EQ(32, buffer->width());
|
|
EXPECT_EQ(16, buffer->height());
|
|
EXPECT_NE(u_ptr, buffer->DataU());
|
|
EXPECT_NE(v_ptr, buffer->DataV());
|
|
}
|
|
|
|
TEST(TestI420BufferPool, FrameValidAfterPoolDestruction) {
|
|
rtc::scoped_refptr<I420Buffer> buffer;
|
|
{
|
|
I420BufferPool pool;
|
|
buffer = pool.CreateBuffer(16, 16);
|
|
}
|
|
EXPECT_EQ(16, buffer->width());
|
|
EXPECT_EQ(16, buffer->height());
|
|
// Try to trigger use-after-free errors by writing to y-plane.
|
|
memset(buffer->MutableDataY(), 0xA5, 16 * buffer->StrideY());
|
|
}
|
|
|
|
TEST(TestI420BufferPool, MaxNumberOfBuffers) {
|
|
I420BufferPool pool(false, 1);
|
|
rtc::scoped_refptr<I420BufferInterface> buffer1 = pool.CreateBuffer(16, 16);
|
|
EXPECT_NE(nullptr, buffer1.get());
|
|
EXPECT_EQ(nullptr, pool.CreateBuffer(16, 16).get());
|
|
}
|
|
|
|
} // namespace webrtc
|