
This CL adds ParseStatus/ParseStatusOr classes and returns those instead of CHECKing that the log is well formed. Some refactoring was required. We also add a allow_incomplete_logs parameter to the parser which by default is false. Setting it to true will make the parser log a warning but return success for errors that typically indicate that the log has been truncated. "Deeper" errors indicating log corruption still return an error. Bug: webrtc:11064 Change-Id: Id5bd6e321de07e250662ae3aaa5ef15f48db6d55 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/158746 Reviewed-by: Ivo Creusen <ivoc@webrtc.org> Reviewed-by: Sebastian Jansson <srte@webrtc.org> Commit-Queue: Björn Terelius <terelius@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29679}
NetEQ RTP Play tool
Testing of the command line arguments
The command line tool neteq_rtpplay
can be tested by running neteq_rtpplay_test.sh
, which is not use on try bots, but it can be used before submitting any CLs that may break the behavior of the command line arguments of neteq_rtpplay
.
Run neteq_rtpplay_test.sh
as follows from the src/
folder:
src$ ./modules/audio_coding/neteq/tools/neteq_rtpplay_test.sh \
out/Default/neteq_rtpplay \
resources/audio_coding/neteq_opus.rtp \
resources/short_mixed_mono_48.pcm
You can replace the RTP and PCM files with any other compatible files.
If you get an error using the files indicated above, try running gclient sync
.
Requirements: awk
and md5sum
.