database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

[fix](publish version) publish version task no need return VERSION_NOT_EXIST #27005

Browse Source 
if BE's tablet not contains a txn, publish txn on them will no error, when check version exists it will indicate the tablet as error_tablet_id in task's response, so FE can know this tablet has fail.

Also for task, it's no need to set its status as "VERSION_NOT_EXIST". Because if set it as not ok, the BE will try this task two times. Since not contains this tablet's txn, the retry is in vain.
This commit is contained in:
yujun
2023-11-15 21:09:54 +08:00
committed by GitHub
parent 4dda5aad09
commit 10ee48bb6f
1 changed files with 0 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
be/src/olap/task/engine_publish_version_task.cpp
View File

@ -242,12 +242,6 @@ Status EnginePublishVersionTask::finish() {
(*_succ_tablets)[tablet_id] = 0;
} else {
add_error_tablet_id(tablet_id);
if (res.ok()) {
res = Status::Error<VERSION_NOT_EXIST>(
"tablet {} with state {} not exists version {}", tablet_id,
tablet_state_name(tablet->tablet_state()),
par_ver_info.version);
}
LOG(WARNING)
<< "publish version failed on transaction, tablet version not "
"exists. "