database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

[fix](nereids)fix logical repeat computefd (#47798)

Browse Source
This commit is contained in:
xzj7019
2025-02-13 16:27:30 +08:00
committed by GitHub
parent 058929528c
commit 13c8b1797d
2 changed files with 10 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/logical/LogicalRepeat.java
View File

@ -192,17 +192,12 @@ public class LogicalRepeat<CHILD_TYPE extends Plan> extends LogicalUnary<CHILD_T
@Override
public void computeUniform(FunctionalDependencies.Builder fdBuilder) {
fdBuilder.addUniformSlot(child(0).getLogicalProperties().getFunctionalDependencies());
// don't generate uniform slot
}
@Override
public ImmutableSet<FdItem> computeFdItems() {
ImmutableSet.Builder<FdItem> builder = ImmutableSet.builder();
ImmutableSet<FdItem> childItems = child().getLogicalProperties().getFunctionalDependencies().getFdItems();
builder.addAll(childItems);
return builder.build();
return ImmutableSet.of();
}
@Override

15
fe/fe-core/src/test/java/org/apache/doris/nereids/properties/FunctionalDependenciesTest.java
View File

@ -236,13 +236,14 @@ class FunctionalDependenciesTest extends TestWithFeService {
Assertions.assertTrue(plan.getLogicalProperties()
.getFunctionalDependencies().isUniformAndNotNull(plan.getOutput().get(0)));
plan = PlanChecker.from(connectContext)
.analyze("select id from agg where id = 1 group by cube(id, name)")
.rewrite()
.getPlan();
System.out.println(plan.getLogicalProperties().getFunctionalDependencies());
Assertions.assertTrue(plan.getLogicalProperties()
.getFunctionalDependencies().isUniform(plan.getOutput().get(0)));
// comment this ut since repeat's uniform and fd are disabled in this version
//plan = PlanChecker.from(connectContext)
// .analyze("select id from agg where id = 1 group by cube(id, name)")
// .rewrite()
// .getPlan();
//System.out.println(plan.getLogicalProperties().getFunctionalDependencies());
//Assertions.assertTrue(plan.getLogicalProperties()
// .getFunctionalDependencies().isUniform(plan.getOutput().get(0)));
}
@Test