database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

[bugfix](potential bug) add lock when modify total tasks number (#27428)

Browse Source 
Co-authored-by: yiguolei <yiguolei@gmail.com>
This commit is contained in:
yiguolei
2023-11-23 09:28:09 +08:00
committed by GitHub
parent fe5c4e3b46
commit 179d4ab754
1 changed files with 12 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
be/src/pipeline/pipeline_fragment_context.cpp
View File

@ -703,9 +703,18 @@ Status PipelineFragmentContext::submit() {
for (auto& task : _tasks) {
st = scheduler->schedule_task(task.get());
if (!st) {
std::lock_guard<std::mutex> l(_status_lock);
cancel(PPlanFragmentCancelReason::INTERNAL_ERROR, "submit context fail");
_total_tasks = submit_tasks;
{
std::lock_guard<std::mutex> l(_status_lock);
cancel(PPlanFragmentCancelReason::INTERNAL_ERROR, "submit context fail");
}
{
// The fragment instance may contains 10 tasks, maybe 8 of them is in scheduler running
// and the 9th failed to add to scheduler, then it will update total_tasks.
// But the previous 8 tasks may finished and try to access total_tasks. So that
// has to use a lock to protect it.
std::lock_guard<std::mutex> l(_task_mutex);
_total_tasks = submit_tasks;
}
break;
}
submit_tasks++;