database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

[Bug](memtable) fix a bug occurred when we were inserting data into duplicate table without keys (#20233)

Browse Source
This commit is contained in:
yangshijie
2023-05-31 18:21:36 +08:00
committed by GitHub
parent d963bf8d79
commit 1aefc26ca0
1 changed files with 6 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
be/src/olap/memtable.cpp
View File

@ -238,11 +238,6 @@ void MemTable::_aggregate_two_row_in_block(vectorized::MutableBlock& mutable_blo
}
void MemTable::_put_into_output(vectorized::Block& in_block) {
SCOPED_RAW_TIMER(&_stat.put_into_output_ns);
if (_keys_type == KeysType::DUP_KEYS && _schema->num_key_columns() == 0) {
// skip sort if the table is dup table without keys
_output_mutable_block.swap(_input_mutable_block);
return;
}
std::vector<int> row_pos_vec;
DCHECK(in_block.rows() <= std::numeric_limits<int>::max());
row_pos_vec.reserve(in_block.rows());
@ -470,8 +465,12 @@ Status MemTable::_do_flush() {
SCOPED_CONSUME_MEM_TRACKER(_flush_mem_tracker);
int same_keys_num = _sort();
if (_keys_type == KeysType::DUP_KEYS || same_keys_num == 0) {
vectorized::Block in_block = _input_mutable_block.to_block();
_put_into_output(in_block);
if (_keys_type == KeysType::DUP_KEYS && _schema->num_key_columns() == 0) {
_output_mutable_block.swap(_input_mutable_block);
} else {
vectorized::Block in_block = _input_mutable_block.to_block();
_put_into_output(in_block);
}
} else {
_aggregate<true>();
}