database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

[fix](metric) Fix be core when set enable_system_metrics to false in be (#16646)

Browse Source 
when enable_system_metrics is false, we should not use system_metrics any more

Co-authored-by: caiconghui1 <caiconghui1@jd.com>
This commit is contained in:
caiconghui
2023-02-12 23:01:41 +08:00
committed by GitHub
parent cf739e7496
commit 1de4e312cc
2 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
be/src/common/configbase.cpp
View File

@ -439,9 +439,8 @@ Status set_fuzzy_config(const std::string& field, const std::string& value) {
void set_fuzzy_configs() {
// random value true or false
Status s =
set_fuzzy_config("disable_storage_page_cache", ((rand() % 2) == 0) ? "true" : "false");
LOG(INFO) << s.to_string();
set_fuzzy_config("disable_storage_page_cache", ((rand() % 2) == 0) ? "true" : "false");
set_fuzzy_config("enable_system_metrics", ((rand() % 2) == 0) ? "true" : "false");
// random value from 8 to 48
// s = set_fuzzy_config("doris_scanner_thread_pool_thread_num", std::to_string((rand() % 41) + 8));
// LOG(INFO) << s.to_string();

4
be/src/common/daemon.cpp
View File

@ -181,7 +181,9 @@ void Daemon::memory_maintenance_thread() {
// Refresh allocator memory metrics.
#if !defined(ADDRESS_SANITIZER) && !defined(LEAK_SANITIZER) && !defined(THREAD_SANITIZER)
doris::MemInfo::refresh_allocator_mem();
DorisMetrics::instance()->system_metrics()->update_allocator_metrics();
if (config::enable_system_metrics) {
DorisMetrics::instance()->system_metrics()->update_allocator_metrics();
}
#endif
doris::MemInfo::refresh_proc_mem_no_allocator_cache();