database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

[chore](Nereids): remove useless code (#22960)

Browse Source
This commit is contained in:
jakevin
2023-08-15 13:14:20 +08:00
committed by GitHub
parent 707a527775
commit 1eab93b368
3 changed files with 1 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/GroupPlan.java
View File

@ -86,12 +86,6 @@ public class GroupPlan extends LogicalLeaf {
+ " You should invoke GroupPlan.getOutput()");
}
@Override
public LogicalProperties computeLogicalProperties() {
throw new IllegalStateException("GroupPlan can not compute logical properties."
+ " You should invoke GroupPlan.getLogicalProperties()");
}
@Override
public <R, C> R accept(PlanVisitor<R, C> visitor, C context) {
return visitor.visitGroupPlan(this, context);

9
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/logical/AbstractLogicalPlan.java
View File

@ -27,15 +27,11 @@ import org.apache.doris.qe.ConnectContext;
import java.util.List;
import java.util.Optional;
import java.util.function.Supplier;
/**
* Abstract class for all concrete logical plan.
*/
public abstract class AbstractLogicalPlan extends AbstractPlan implements LogicalPlan, Explainable {
private final Supplier<Boolean> hasUnboundExpressions = super::hasUnboundExpression;
public AbstractLogicalPlan(PlanType type, Plan... children) {
super(type, children);
}
@ -50,11 +46,6 @@ public abstract class AbstractLogicalPlan extends AbstractPlan implements Logica
super(type, groupExpression, logicalProperties, null, children);
}
@Override
public boolean hasUnboundExpression() {
return hasUnboundExpressions.get();
}
@Override
public Plan getExplainPlan(ConnectContext ctx) {
return this;

11
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/logical/LogicalSetOperation.java
View File

@ -20,7 +20,6 @@ package org.apache.doris.nereids.trees.plans.logical;
import org.apache.doris.catalog.Type;
import org.apache.doris.nereids.memo.GroupExpression;
import org.apache.doris.nereids.properties.LogicalProperties;
import org.apache.doris.nereids.properties.UnboundLogicalProperties;
import org.apache.doris.nereids.trees.expressions.Alias;
import org.apache.doris.nereids.trees.expressions.Cast;
import org.apache.doris.nereids.trees.expressions.Expression;
@ -86,15 +85,7 @@ public abstract class LogicalSetOperation extends AbstractLogicalPlan implements
@Override
public boolean hasUnboundExpression() {
return outputs.isEmpty() || super.hasUnboundExpression();
}
@Override
public LogicalProperties computeLogicalProperties() {
if (outputs.isEmpty()) {
return UnboundLogicalProperties.INSTANCE;
}
return super.computeLogicalProperties();
return outputs.isEmpty();
}
@Override