database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

[Bug] Base compaction failed because of overlapping of input rowsets (#3262)

Browse Source 
When calculating the cumulative point at first time, we should stop increasing
the cumulative point when we meet a rowset with overlap flag as OVERLAPPING,
even if it has only one segments.
This commit is contained in:
Mingyu Chen
2020-04-07 11:26:57 +08:00
committed by GitHub
parent 79bac50361
commit 1ef4cb2d24
1 changed files with 12 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
be/src/olap/tablet.cpp
View File

@ -716,6 +716,8 @@ OLAPStatus Tablet::_max_continuous_version_from_begining_unlocked(Version* versi
OLAPStatus Tablet::calculate_cumulative_point() {
WriteLock wrlock(&_meta_lock);
if (_cumulative_point != -1) {
// only calculate the point once.
// after that, cumulative point will be updated along with compaction process.
return OLAP_SUCCESS;
}
@ -736,7 +738,16 @@ OLAPStatus Tablet::calculate_cumulative_point() {
// There is a hole, do not continue
break;
}
if (rs->is_segments_overlapping()) {
// break the loop if segments in this rowset is overlapping, or overlap flag is NOT NONOVERLAPPING
// even if is_segments_overlapping() return false, the overlap flag may be OVERLAPPING.
// eg: tablet with versions(rowsets):
// [0-1] NONOVERLAPPING
// [2-2] OVERLAPPING
// [2-2]'s overlap flag is OVERLAPPING because it is newly written by the delta writer.
// but is has only one segment, so is_segments_overlapping() will return false.
// but we should not continue increasing the cumulative point, because we need
// the compaction process to change the overlap flag from OVERLAPPING to NONOVERLAPPING.
if (rs->is_segments_overlapping() || rs->segments_overlap() != NONOVERLAPPING) {
_cumulative_point = rs->version().first;
break;
}