database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

[Meta] Add some consistency check in image put api (#5219)

Browse Source
This commit is contained in:
gengjun-git
2021-01-23 21:08:04 +08:00
committed by GitHub
parent a5298d617d
commit 2ddf537094
1 changed files with 22 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
fe/fe-core/src/main/java/org/apache/doris/http/meta/MetaService.java
View File

@ -173,7 +173,28 @@ public class MetaService {
writeResponse(request, response, HttpResponseStatus.BAD_REQUEST);
return;
}
checkLongParam(versionStr);
long version = checkLongParam(versionStr);
// for master node, reject image put
if (Catalog.getCurrentCatalog().isMaster()) {
response.appendContent("this node is master, reject image put");
writeResponse(request, response, HttpResponseStatus.BAD_REQUEST);
LOG.error("this node is master, but receive image put from host {}, reject it", machine);
return;
}
// do not accept image whose version is bigger than max journalId
// if accepted, newly added log will not be replayed when restart
long maxJournalId = Catalog.getCurrentCatalog().getMaxJournalId();
if (version > maxJournalId) {
response.appendContent("image version [" + version + "] is bigger than local max journal id ["
+ maxJournalId + "], reject image put");
writeResponse(request, response, HttpResponseStatus.BAD_REQUEST);
LOG.error("receive image whose version [{}] is bigger than local max journal id [{}], reject it",
version, maxJournalId);
return;
}
String url = "http://" + machine + ":" + portStr
+ "/image?version=" + versionStr;