database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

Fix bug that unable to delete redundant replicas (#1442)

Browse Source 
This can happen if the Doris cluster is deployed with all, for example, SSD medium,
but create all tables with HDD storage medium property. Then getLoadScore(SSD) will
always return 0.0, so that no replica will be chosen when try to delete redundant
replicas.
This commit is contained in:
Mingyu Chen
2019-07-09 10:38:35 +08:00
committed by ZHAO Chun
parent ded60e59f9
commit 3202dc28e8
1 changed files with 17 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
fe/src/main/java/org/apache/doris/clone/TabletScheduler.java
View File

@ -772,8 +772,23 @@ public class TabletScheduler extends Daemon {
if (beStatistic == null) {
continue;
}
if (beStatistic.getLoadScore(tabletCtx.getStorageMedium()) > maxScore) {
maxScore = beStatistic.getLoadScore(tabletCtx.getStorageMedium());
/*
* If the backend does not have the specified storage medium, we use mix load score to make
* sure that at least one replica can be chosen.
* This can happen if the Doris cluster is deployed with all, for example, SSD medium,
* but create all tables with HDD storage medium property. Then getLoadScore(SSD) will
* always return 0.0, so that no replica will be chosen.
*/
double loadScore = 0.0;
if (beStatistic.hasMedium(tabletCtx.getStorageMedium())) {
loadScore = beStatistic.getLoadScore(tabletCtx.getStorageMedium());
} else {
loadScore = beStatistic.getMixLoadScore();
}
if (loadScore > maxScore) {
maxScore = loadScore;
chosenReplica = replica;
}
}