database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

[fix](regression) mow cases should use assertEquals not assertTrue (#28338)

Browse Source
This commit is contained in:
meiyi
2023-12-13 22:14:32 +08:00
committed by GitHub
parent a271fee3c5
commit 33e24436d6
5 changed files with 23 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
regression-test/suites/inverted_index_p0/unique_with_mow/test_pk_uk_case.groovy
View File

@ -197,10 +197,7 @@ suite("test_pk_uk_case", "inverted_index") {
def result0 = sql """ SELECT count(*) FROM ${tableNamePk}; """
def result1 = sql """ SELECT count(*) FROM ${tableNameUk}; """
logger.info("result:" + result0[0][0] + "|" + result1[0][0])
assertTrue(result0[0]==result1[0])
if (result0[0][0]!=result1[0][0]) {
logger.info("result:" + result0[0][0] + "|" + result1[0][0])
}
assertEquals(result0[0], result1[0])
result0 = sql """ SELECT
l_returnflag,
@ -242,11 +239,11 @@ suite("test_pk_uk_case", "inverted_index") {
l_returnflag,
l_linestatus
"""
assertTrue(result0.size()==result1.size())
assertEquals(result0.size(), result1.size())
for (int i = 0; i < result0.size(); ++i) {
for (j = 0; j < result0[0].size(); j++) {
for (int j = 0; j < result0[0].size(); j++) {
logger.info("result: " + result0[i][j] + "|" + result1[i][j])
assertTrue(result0[i][j]==result1[i][j])
assertEquals(result0[i][j], result1[i][j])
}
}

11
regression-test/suites/unique_with_mow_p0/cluster_key/test_pk_uk_case.groovy
View File

@ -193,10 +193,7 @@ suite("test_pk_uk_case") {
def result0 = sql """ SELECT count(*) FROM ${tableNamePk}; """
def result1 = sql """ SELECT count(*) FROM ${tableNameUk}; """
logger.info("result:" + result0[0][0] + "|" + result1[0][0])
assertTrue(result0[0]==result1[0])
if (result0[0][0]!=result1[0][0]) {
logger.info("result:" + result0[0][0] + "|" + result1[0][0])
}
assertEquals(result0[0], result1[0])
result0 = sql """ SELECT
l_returnflag,
@ -238,11 +235,11 @@ suite("test_pk_uk_case") {
l_returnflag,
l_linestatus
"""
assertTrue(result0.size()==result1.size())
assertEquals(result0.size(), result1.size())
for (int i = 0; i < result0.size(); ++i) {
for (j = 0; j < result0[0].size(); j++) {
for (int j = 0; j < result0[0].size(); j++) {
logger.info("result: " + result0[i][j] + "|" + result1[i][j])
assertTrue(result0[i][j]==result1[i][j])
assertEquals(result0[i][j], result1[i][j])
}
}

13
regression-test/suites/unique_with_mow_p0/test_pk_uk_case.groovy
View File

@ -190,10 +190,7 @@ suite("test_pk_uk_case") {
def result0 = sql """ SELECT count(*) FROM ${tableNamePk}; """
def result1 = sql """ SELECT count(*) FROM ${tableNameUk}; """
logger.info("result:" + result0[0][0] + "|" + result1[0][0])
assertTrue(result0[0]==result1[0])
if (result0[0][0]!=result1[0][0]) {
logger.info("result:" + result0[0][0] + "|" + result1[0][0])
}
assertEquals(result0[0], result1[0])
result0 = sql """ SELECT
l_returnflag,
@ -234,12 +231,12 @@ suite("test_pk_uk_case") {
ORDER BY
l_returnflag,
l_linestatus
"""
assertTrue(result0.size()==result1.size())
"""
assertEquals(result0.size(), result1.size())
for (int i = 0; i < result0.size(); ++i) {
for (j = 0; j < result0[0].size(); j++) {
for (int j = 0; j < result0[0].size(); j++) {
logger.info("result: " + result0[i][j] + "|" + result1[i][j])
assertTrue(result0[i][j]==result1[i][j])
assertEquals(result0[i][j], result1[i][j])
}
}

13
regression-test/suites/unique_with_mow_p2/test_pk_uk_case.groovy
View File

@ -190,10 +190,7 @@ suite("test_pk_uk_case") {
def result0 = sql """ SELECT count(*) FROM ${tableNamePk}; """
def result1 = sql """ SELECT count(*) FROM ${tableNameUk}; """
logger.info("result:" + result0[0][0] + "|" + result1[0][0])
assertTrue(result0[0]==result1[0])
if (result0[0][0]!=result1[0][0]) {
logger.info("result:" + result0[0][0] + "|" + result1[0][0])
}
assertEquals(result0[0], result1[0])
result0 = sql """ SELECT
l_returnflag,
@ -234,12 +231,12 @@ suite("test_pk_uk_case") {
ORDER BY
l_returnflag,
l_linestatus
"""
assertTrue(result0.size()==result1.size())
"""
assertEquals(result0.size(), result1.size())
for (int i = 0; i < result0.size(); ++i) {
for (j = 0; j < result0[0].size(); j++) {
for (int j = 0; j < result0[0].size(); j++) {
logger.info("result: " + result0[i][j] + "|" + result1[i][j])
assertTrue(result0[i][j]==result1[i][j])
assertEquals(result0[i][j], result1[i][j])
}
}

13
regression-test/suites/unique_with_mow_p2/test_pk_uk_case_cluster.groovy
View File

@ -191,10 +191,7 @@ suite("test_pk_uk_case_cluster") {
def result0 = sql """ SELECT count(*) FROM ${tableNamePk}; """
def result1 = sql """ SELECT count(*) FROM ${tableNameUk}; """
logger.info("result:" + result0[0][0] + "|" + result1[0][0])
assertTrue(result0[0]==result1[0])
if (result0[0][0]!=result1[0][0]) {
logger.info("result:" + result0[0][0] + "|" + result1[0][0])
}
assertEquals(result0[0], result1[0])
result0 = sql """ SELECT
l_returnflag,
@ -235,12 +232,12 @@ suite("test_pk_uk_case_cluster") {
ORDER BY
l_returnflag,
l_linestatus
"""
assertTrue(result0.size()==result1.size())
"""
assertEquals(result0.size(), result1.size())
for (int i = 0; i < result0.size(); ++i) {
for (j = 0; j < result0[0].size(); j++) {
for (int j = 0; j < result0[0].size(); j++) {
logger.info("result: " + result0[i][j] + "|" + result1[i][j])
assertTrue(result0[i][j]==result1[i][j])
assertEquals(result0[i][j], result1[i][j])
}
}