database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

[fix](array-type) forbid to create materialized view for array column (#12543)

Browse Source 
Co-authored-by: hucheng01 <hucheng01@baidu.com>
This commit is contained in:
carlvinhust2012
2022-09-15 11:08:23 +08:00
committed by GitHub
parent e413a2b8e9
commit 33f5a86e69
2 changed files with 83 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
fe/fe-core/src/main/java/org/apache/doris/alter/MaterializedViewHandler.java
View File

@ -505,6 +505,12 @@ public class MaterializedViewHandler extends AlterHandler {
if (KeysType.UNIQUE_KEYS == olapTable.getKeysType() && olapTable.hasSequenceCol()) {
newMVColumns.add(new Column(olapTable.getSequenceCol()));
}
// if the column is array type, we forbid to create materialized view
for (Column column : newMVColumns) {
if (column.getDataType() == PrimitiveType.ARRAY) {
throw new DdlException("The array column[" + column + "] not support to create materialized view");
}
}
if (olapTable.getEnableLightSchemaChange()) {
int nextColUniqueId = Column.COLUMN_UNIQUE_ID_INIT_VALUE + 1;

77
regression-test/suites/rollup_p0/test_materialized_view_array.groovy Normal file
View File

@ -0,0 +1,77 @@
// Licensed to the Apache Software Foundation (ASF) under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The ASF licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you may not use this file except in compliance
// with the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing,
// software distributed under the License is distributed on an
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
// KIND, either express or implied. See the License for the
// specific language governing permissions and limitations
// under the License.
suite("test_materialized_view_array", "rollup") {
def tableName = "tbl_test_materialized_view_array"
def create_test_table = {testTable ->
// multi-line sql
sql "ADMIN SET FRONTEND CONFIG ('enable_array_type' = 'true')"
def result1 = sql """
CREATE TABLE IF NOT EXISTS ${tableName} (
`k1` int(11) NULL,
`k2` array<smallint(6)> NULL,
`k3` array<int(11)> NULL,
`k4` array<bigint(20)> NULL,
`k5` array<char(20)> NULL,
`k6` array<varchar(50)> NULL,
`k7` array<date> NULL,
`k8` array<datetime> NULL,
`k9` array<float> NULL,
`k10` array<double> NULL,
`k11` array<decimal(20, 6)> NULL,
`k12` array<boolean> NULL,
`k13` array<text> NULL
) ENGINE=OLAP
DUPLICATE KEY(`k1`)
COMMENT 'OLAP'
DISTRIBUTED BY HASH(`k1`) BUCKETS 1
PROPERTIES (
"replication_allocation" = "tag.location.default: 1",
"in_memory" = "false",
"storage_format" = "V2",
"disable_auto_compaction" = "false"
)
"""
// DDL/DML return 1 row and 3 column, the only value is update row count
assertTrue(result1.size() == 1)
assertTrue(result1[0].size() == 1)
assertTrue(result1[0][0] == 0, "Create table should update 0 rows")
// insert 1 row to check whether the table is ok
def result2 = sql """ INSERT INTO ${tableName} VALUES (100, [1, 2, 3], [32767, 32768, 32769], [65534, 65535, 65536],
['a', 'b', 'c'], ["hello", "world"], ['2022-07-13'], ['2022-07-13 12:30:00'], [0.33, 0.67], [3.1415926, 0.878787878],
[4, 5.5, 6.67], [true, false], ['happy life'])
"""
assertTrue(result2.size() == 1)
assertTrue(result2[0].size() == 1)
assertTrue(result2[0][0] == 1, "Insert should update 1 rows")
}
try {
sql "DROP TABLE IF EXISTS ${tableName}"
create_test_table.call(tableName)
test {
sql "CREATE MATERIALIZED VIEW idx AS select k1, k2, k3, k4, k5 from ${tableName}"
exception "errCode = 2, detailMessage = The array column[`k2` array<smallint(6)> NULL] not support to create materialized view"
}
} finally {
try_sql("DROP TABLE IF EXISTS ${tableName}")
}
}