database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

[Chore](sort) fix block used after it was moved(#29416)

Browse Source 
/mnt/disk2/pengyu/codebase/apache/doris/be/src/vec/common/sort/heap_sorter.cpp:91:23: error: 'tmp_block' used after it was moved [bugprone-use-after-move,-warnings-as-errors]
This commit is contained in:
Pxl
2024-01-03 10:02:35 +08:00
committed by GitHub
parent cdf2bb24a4
commit 358995e4ac
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
be/src/vec/common/sort/heap_sorter.cpp
View File

@ -83,12 +83,11 @@ Status HeapSorter::append_block(Block* block) {
}
Block tmp_block = block->clone_empty();
tmp_block.swap(*block);
size_t num_rows = tmp_block.rows();
HeapSortCursorBlockView block_view_val(std::move(tmp_block), _sort_description);
SharedHeapSortCursorBlockView* block_view =
new SharedHeapSortCursorBlockView(std::move(block_view_val));
auto* block_view = new SharedHeapSortCursorBlockView(std::move(block_view_val));
block_view->ref();
Defer defer([&] { block_view->unref(); });
size_t num_rows = tmp_block.rows();
if (_heap_size == _heap->size()) {
{
SCOPED_TIMER(_topn_filter_timer);