database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

[BUG] fix profile not working with sql_cache enabled (#7105)

Browse Source 
Fix profile not working in sql_cache enabled. It will thrown NullPointerException.
The reason is that the Coordinator in init profile is null when cache is enable.
Therefore, we should perform different profile processing in the case of cache hits and misses, so as to avoid the situation of null pointers.

Fixed #7104
This commit is contained in:
qiye
2021-11-17 14:38:00 +08:00
committed by GitHub
parent f5a35c28e9
commit 36360ba846
1 changed files with 12 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
fe/fe-core/src/main/java/org/apache/doris/qe/StmtExecutor.java
View File

@ -195,6 +195,13 @@ public class StmtExecutor implements ProfileWriter {
private void initProfile(QueryPlannerProfile plannerProfile, boolean waiteBeReport) {
long currentTimestamp = System.currentTimeMillis();
long totalTimeMs = currentTimestamp - context.getStartTime();
RuntimeProfile queryProfile;
// when a query hits the sql cache, `coord` is null.
if (coord == null) {
queryProfile = new RuntimeProfile("Execution Profile " + DebugUtil.printId(context.queryId()));
} else {
queryProfile = coord.getQueryProfile();
}
if (profile == null) {
profile = new RuntimeProfile("Query");
summaryProfile = new RuntimeProfile("Summary");
@ -216,7 +223,7 @@ public class StmtExecutor implements ProfileWriter {
plannerRuntimeProfile = new RuntimeProfile("Execution Summary");
summaryProfile.addChild(plannerRuntimeProfile);
profile.addChild(coord.getQueryProfile());
profile.addChild(queryProfile);
} else {
summaryProfile.addInfoString(ProfileManager.END_TIME,
waiteBeReport ? TimeUtils.longToTimeString(currentTimestamp) : "N/A");
@ -227,8 +234,10 @@ public class StmtExecutor implements ProfileWriter {
}
plannerProfile.initRuntimeProfile(plannerRuntimeProfile);
coord.getQueryProfile().getCounterTotalTime().setValue(TimeUtils.getEstimatedTime(plannerProfile.getQueryBeginTime()));
coord.endProfile(waiteBeReport);
queryProfile.getCounterTotalTime().setValue(TimeUtils.getEstimatedTime(plannerProfile.getQueryBeginTime()));
if (coord != null) {
coord.endProfile(waiteBeReport);
}
}
public Planner planner() {