database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

[opt](Nereids) always fallback when parse failed (#21865)

Browse Source 
always fallback to legacy planner when parse failed even if enable_fallback_to_original_planner is set to false
This commit is contained in:
Xiangyu Wang
2023-07-25 17:08:57 +08:00
committed by GitHub
parent 527547b4ed
commit 39ca91fc22
1 changed files with 0 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
fe/fe-core/src/main/java/org/apache/doris/qe/ConnectProcessor.java
View File

@ -24,7 +24,6 @@ import org.apache.doris.analysis.LiteralExpr;
import org.apache.doris.analysis.NullLiteral;
import org.apache.doris.analysis.Queriable;
import org.apache.doris.analysis.QueryStmt;
import org.apache.doris.analysis.SelectStmt;
import org.apache.doris.analysis.SqlParser;
import org.apache.doris.analysis.SqlScanner;
import org.apache.doris.analysis.StatementBase;
@ -371,7 +370,6 @@ public class ConnectProcessor {
.setUser(ClusterNamespace.getNameFromFullName(ctx.getQualifiedUser()))
.setSqlHash(ctx.getSqlHash());
Exception nereidsParseException = null;
List<StatementBase> stmts = null;
// Nereids do not support prepare and execute now, so forbid prepare command, only process query command
@ -388,7 +386,6 @@ public class ConnectProcessor {
}
} catch (Exception e) {
// TODO: We should catch all exception here until we support all query syntax.
nereidsParseException = e;
LOG.debug("Nereids parse sql failed. Reason: {}. Statement: \"{}\".",
e.getMessage(), originStmt);
}
@ -425,17 +422,6 @@ public class ConnectProcessor {
}
StatementBase parsedStmt = stmts.get(i);
if (parsedStmt instanceof SelectStmt && nereidsParseException != null
&& ctx.getSessionVariable().isEnableNereidsPlanner()
&& !ctx.getSessionVariable().enableFallbackToOriginalPlanner) {
Exception exception = new Exception(
String.format("Nereids cannot parse the SQL, and fallback disabled. caused by: \n\n%s",
nereidsParseException.getMessage()), nereidsParseException);
// audit it and break
handleQueryException(exception, auditStmt, null, null);
break;
}
parsedStmt.setOrigStmt(new OriginStatement(originStmt, i));
parsedStmt.setUserInfo(ctx.getCurrentUserIdentity());
executor = new StmtExecutor(ctx, parsedStmt);