database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

[fix](Nereids) topn arg check is not compatible with legacy planner (#16105)

Browse Source
This commit is contained in:
morrySnow
2023-01-20 15:08:10 +08:00
committed by GitHub
parent 72df283344
commit 419f433d21
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/agg/TopN.java
View File

@ -77,12 +77,12 @@ public class TopN extends AggregateFunction
@Override
public void checkLegalityBeforeTypeCoercion() {
if (!getArgument(1).isConstant() || !getArgumentType(1).isIntegerType()) {
if (!getArgument(1).isConstant() || !getArgumentType(1).isIntegerLikeType()) {
throw new AnalysisException(
"topn requires second parameter must be a constant Integer Type: " + this.toSql());
}
if (arity() == 3) {
if (!getArgument(2).isConstant() || !getArgumentType(2).isIntegerType()) {
if (!getArgument(2).isConstant() || !getArgumentType(2).isIntegerLikeType()) {
throw new AnalysisException(
"topn requires the third parameter must be a constant Integer Type: " + this.toSql());
}

2
fe/fe-core/src/main/java/org/apache/doris/nereids/types/DataType.java
View File

@ -438,7 +438,7 @@ public abstract class DataType implements AbstractDataType {
}
public boolean isIntegerLikeType() {
return this instanceof IntegralType;
return this instanceof IntegralType && !(this instanceof LargeIntType);
}
public boolean isTinyIntType() {