database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

[improvement](MOW) use shared_lock when get load info in publish txn (#16874)

Browse Source
This commit is contained in:
yixiutt
2023-02-21 10:14:40 +08:00
committed by GitHub
parent 08adf914f9
commit 4522aeb74a
2 changed files with 5 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
be/src/olap/task/engine_publish_version_task.cpp
View File

@ -183,11 +183,9 @@ Status EnginePublishVersionTask::finish() {
}
}
VLOG_CRITICAL << "finish to publish version on transaction."
<< "transaction_id=" << transaction_id
<< ", cost(us): " << watch.get_elapse_time_us()
<< ", error_tablet_size=" << _error_tablet_ids->size()
<< ", res=" << res.to_string();
LOG(INFO) << "finish to publish version on transaction."
<< "transaction_id=" << transaction_id << ", cost(us): " << watch.get_elapse_time_us()
<< ", error_tablet_size=" << _error_tablet_ids->size() << ", res=" << res.to_string();
return res;
}

4
be/src/olap/txn_manager.cpp
View File

@ -292,9 +292,9 @@ Status TxnManager::publish_txn(OlapMeta* meta, TPartitionId partition_id,
RowsetSharedPtr rowset_ptr = nullptr;
TabletTxnInfo* load_info = nullptr;
{
std::unique_lock<std::mutex> txn_lock(_get_txn_lock(transaction_id));
{
std::shared_lock rlock(_get_txn_map_lock(transaction_id));
std::unique_lock<std::mutex> txn_rlock(_get_txn_lock(transaction_id));
std::shared_lock txn_map_rlock(_get_txn_map_lock(transaction_id));
txn_tablet_map_t& txn_tablet_map = _get_txn_tablet_map(transaction_id);
auto it = txn_tablet_map.find(key);
if (it != txn_tablet_map.end()) {