database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

[improve](function) get result from constant_col when expr is const (#29403)

Browse Source
This commit is contained in:
zhangstar333
2024-01-05 11:26:17 +08:00
committed by GitHub
parent baec2657dd
commit 46ccbebfb0
5 changed files with 23 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
be/src/vec/exprs/vcase_expr.cpp
View File

@ -95,6 +95,9 @@ void VCaseExpr::close(VExprContext* context, FunctionContext::FunctionStateScope
}
Status VCaseExpr::execute(VExprContext* context, Block* block, int* result_column_id) {
if (is_const_and_have_executed()) { // const have execute in open function
return get_result_from_const(block, _expr_name, result_column_id);
}
ColumnNumbers arguments(_children.size());
for (int i = 0; i < _children.size(); i++) {
int column_id = -1;

4
be/src/vec/exprs/vectorized_fn_call.cpp
View File

@ -138,6 +138,10 @@ void VectorizedFnCall::close(VExprContext* context, FunctionContext::FunctionSta
Status VectorizedFnCall::execute(VExprContext* context, vectorized::Block* block,
int* result_column_id) {
if (is_const_and_have_executed()) { // const have execute in open function
return get_result_from_const(block, _expr_name, result_column_id);
}
// TODO: not execute const expr again, but use the const column in function context
vectorized::ColumnNumbers arguments(_children.size());
for (int i = 0; i < _children.size(); ++i) {

8
be/src/vec/exprs/vexpr.cpp
View File

@ -554,4 +554,12 @@ Status VExpr::check_constant(const Block& block, ColumnNumbers arguments) const
return Status::OK();
}
Status VExpr::get_result_from_const(vectorized::Block* block, const std::string& expr_name,
int* result_column_id) {
*result_column_id = block->columns();
auto column = ColumnConst::create(_constant_col->column_ptr, block->rows());
block->insert({std::move(column), _data_type, expr_name});
return Status::OK();
}
} // namespace doris::vectorized

5
be/src/vec/exprs/vexpr.h
View File

@ -220,6 +220,11 @@ protected:
return res;
}
bool is_const_and_have_executed() { return (is_constant() && (_constant_col != nullptr)); }
Status get_result_from_const(vectorized::Block* block, const std::string& expr_name,
int* result_column_id);
Status check_constant(const Block& block, ColumnNumbers arguments) const;
/// Helper function that calls ctx->register(), sets fn_context_index_, and returns the

3
be/src/vec/exprs/vin_predicate.cpp
View File

@ -94,6 +94,9 @@ void VInPredicate::close(VExprContext* context, FunctionContext::FunctionStateSc
}
Status VInPredicate::execute(VExprContext* context, Block* block, int* result_column_id) {
if (is_const_and_have_executed()) { // const have execute in open function
return get_result_from_const(block, _expr_name, result_column_id);
}
// TODO: not execute const expr again, but use the const column in function context
doris::vectorized::ColumnNumbers arguments(_children.size());
for (int i = 0; i < _children.size(); ++i) {