database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

[fix](merge-on-write) enable_unique_key_merge_on_write property should only be used for unique table (#18734)

Browse Source
This commit is contained in:
Xin Liao
2023-04-18 18:40:01 +08:00
committed by GitHub
parent 031d35d4a1
commit 4a16eff16d
3 changed files with 105 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
fe/fe-core/src/main/java/org/apache/doris/datasource/InternalCatalog.java
View File

@ -1956,11 +1956,13 @@ public class InternalCatalog implements CatalogIf<Database> {
keysDesc.keysColumnSize(), storageFormat);
olapTable.setDataSortInfo(dataSortInfo);
boolean enableUniqueKeyMergeOnWrite;
try {
enableUniqueKeyMergeOnWrite = PropertyAnalyzer.analyzeUniqueKeyMergeOnWrite(properties);
} catch (AnalysisException e) {
throw new DdlException(e.getMessage());
boolean enableUniqueKeyMergeOnWrite = false;
if (keysType == KeysType.UNIQUE_KEYS) {
try {
enableUniqueKeyMergeOnWrite = PropertyAnalyzer.analyzeUniqueKeyMergeOnWrite(properties);
} catch (AnalysisException e) {
throw new DdlException(e.getMessage());
}
}
olapTable.setEnableUniqueKeyMergeOnWrite(enableUniqueKeyMergeOnWrite);

3
regression-test/suites/ddl_p0/test_create_table.groovy
View File

@ -42,8 +42,7 @@ suite("sql_create_time_range_table") {
properties(
"replication_num"="1",
"light_schema_change"="true",
"compression"="zstd",
"enable_unique_key_merge_on_write" = "true"
"compression"="zstd"
);
"""

97
regression-test/suites/unique_with_mow_p0/test_create_table.groovy Normal file
View File

@ -0,0 +1,97 @@
// Licensed to the Apache Software Foundation (ASF) under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The ASF licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you may not use this file except in compliance
// with the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing,
// software distributed under the License is distributed on an
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
// KIND, either express or implied. See the License for the
// specific language governing permissions and limitations
// under the License.
suite("test_create_table") {
def tableName = "unique_mow_create_table"
sql """ DROP TABLE IF EXISTS ${tableName} """
// duplicate table with enable_unique_key_merge_on_write property
test {
sql """
CREATE TABLE `$tableName` (
`c_custkey` int(11) NOT NULL COMMENT "",
`c_name` varchar(26) NOT NULL COMMENT "",
`c_address` varchar(41) NOT NULL COMMENT "",
`c_city` varchar(11) NOT NULL COMMENT ""
)
DUPLICATE KEY (`c_custkey`)
DISTRIBUTED BY HASH(`c_custkey`) BUCKETS 1
PROPERTIES (
"replication_num" = "1",
"enable_unique_key_merge_on_write" = "true"
);
"""
exception "Unknown properties"
}
// duplicate table with enable_unique_key_merge_on_write property
test {
sql """
CREATE TABLE `$tableName` (
`c_custkey` int(11) NOT NULL COMMENT "",
`c_name` varchar(26) NOT NULL COMMENT "",
`c_address` varchar(41) NOT NULL COMMENT "",
`c_city` varchar(11) NOT NULL COMMENT ""
)
DUPLICATE KEY (`c_custkey`)
DISTRIBUTED BY HASH(`c_custkey`) BUCKETS 1
PROPERTIES (
"replication_num" = "1",
"enable_unique_key_merge_on_write" = "false"
);
"""
exception "Unknown properties"
}
// agg table with enable_unique_key_merge_on_write property
test {
sql """
CREATE TABLE `$tableName` (
`c_custkey` int(11) NOT NULL COMMENT "",
`c_name` varchar(26) max NOT NULL COMMENT "",
`c_address` varchar(41) max NOT NULL COMMENT "",
`c_city` varchar(11) max NOT NULL COMMENT ""
)
AGGREGATE KEY (`c_custkey`)
DISTRIBUTED BY HASH(`c_custkey`) BUCKETS 1
PROPERTIES (
"replication_num" = "1",
"enable_unique_key_merge_on_write" = "true"
);
"""
exception "Unknown properties"
}
// agg table with enable_unique_key_merge_on_write property
test {
sql """
CREATE TABLE `$tableName` (
`c_custkey` int(11) NOT NULL COMMENT "",
`c_name` varchar(26) max NOT NULL COMMENT "",
`c_address` varchar(41) max NOT NULL COMMENT "",
`c_city` varchar(11) max NOT NULL COMMENT ""
)
AGGREGATE KEY (`c_custkey`)
DISTRIBUTED BY HASH(`c_custkey`) BUCKETS 1
PROPERTIES (
"replication_num" = "1",
"enable_unique_key_merge_on_write" = "false"
);
"""
exception "Unknown properties"
}
}