database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

[improvement](config) enlarge default value of create_table_timeout and remove disable_stream_load_2pc (#13520)

Browse Source 
Users do not need to set create_table_timeout, it is a ddl command and when encounter a timeout event
users will set a lager timeout and retry.

Stream load 2pc is used by default in flink connector, so we should not disable it by config, the config
item is useless.
This commit is contained in:
Yongqiang YANG
2022-10-24 11:51:18 +08:00
committed by GitHub
parent e5b0ca4e8c
commit 54545c6446
4 changed files with 1 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
be/src/common/config.h
View File

@ -393,7 +393,6 @@ CONF_mInt32(stream_load_record_batch_size, "50");
CONF_Int32(stream_load_record_expire_time_secs, "28800");
// time interval to clean expired stream load records
CONF_mInt64(clean_stream_load_record_interval_secs, "1800");
CONF_mBool(disable_stream_load_2pc, "false");
// OlapTableSink sender's send interval, should be less than the real response time of a tablet writer rpc.
// You may need to lower the speed when the sink receiver bes are too busy.

4
be/src/http/action/stream_load.cpp
View File

@ -290,10 +290,6 @@ Status StreamLoadAction::_on_header(HttpRequest* http_req, StreamLoadContext* ct
http_req->header(HTTP_FORMAT_KEY));
}
if (ctx->two_phase_commit && config::disable_stream_load_2pc) {
return Status::InternalError("Two phase commit (2PC) for stream load was disabled");
}
// check content length
ctx->body_bytes = 0;
size_t csv_max_body_bytes = config::streaming_load_max_mb * 1024 * 1024;

7
be/src/http/action/stream_load_2pc.cpp
View File

@ -40,13 +40,6 @@ void StreamLoad2PCAction::handle(HttpRequest* req) {
Status status = Status::OK();
std::string status_result;
if (config::disable_stream_load_2pc) {
status = Status::InternalError("Two phase commit (2PC) for stream load was disabled");
status_result = status.to_json();
HttpChannel::send_reply(req, HttpStatus::OK, status_result);
return;
}
StreamLoadContext* ctx = new StreamLoadContext(_exec_env);
ctx->ref();
req->set_handler_ctx(ctx);

2
fe/fe-core/src/main/java/org/apache/doris/common/Config.java
View File

@ -455,7 +455,7 @@ public class Config extends ConfigBase {
* In order not to wait too long for create table(index), set a max timeout.
*/
@ConfField(mutable = true, masterOnly = true)
public static int max_create_table_timeout_second = 60;
public static int max_create_table_timeout_second = 3600;
/**
* Maximal waiting time for all publish version tasks of one transaction to be finished