database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

[fix](be)shouldn't use arena to alloc memory for SingleValueDataString (#23075)

Browse Source 
* [fix](be)shouldn't use arena to alloc memory for SingleValueDataString

* format code
This commit is contained in:
starocean999
2023-08-17 22:18:09 +08:00
committed by GitHub
parent 29ff7b7964
commit 57568ba472
1 changed files with 8 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
be/src/vec/aggregate_functions/aggregate_function_min_max.h
View File

@ -297,7 +297,7 @@ private:
Int32 size = -1; /// -1 indicates that there is no value.
Int32 capacity = 0; /// power of two or zero
char* large_data = nullptr;
std::unique_ptr<char[]> large_data;
public:
static constexpr Int32 AUTOMATIC_STORAGE_SIZE = 64;
@ -314,7 +314,9 @@ public:
bool has() const { return size >= 0; }
const char* get_data() const { return size <= MAX_SMALL_STRING_SIZE ? small_data : large_data; }
const char* get_data() const {
return size <= MAX_SMALL_STRING_SIZE ? small_data : large_data.get();
}
void insert_result_into(IColumn& to) const {
if (has()) {
@ -328,7 +330,6 @@ public:
if (size != -1) {
size = -1;
capacity = 0;
delete[] large_data;
large_data = nullptr;
}
}
@ -356,11 +357,11 @@ public:
} else {
if (capacity < rhs_size) {
capacity = round_up_to_power_of_two_or_zero(rhs_size);
large_data = arena->alloc(capacity);
large_data.reset(new char[capacity]);
}
size = rhs_size;
buf.read(large_data, size);
buf.read(large_data.get(), size);
}
} else {
/// Don't free large_data here.
@ -385,11 +386,11 @@ public:
if (capacity < value_size) {
/// Don't free large_data here.
capacity = round_up_to_power_of_two_or_zero(value_size);
large_data = arena->alloc(capacity);
large_data.reset(new char[capacity]);
}
size = value_size;
memcpy(large_data, value.data, size);
memcpy(large_data.get(), value.data, size);
}
}