database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

[fix](Nereids) forbid two TVF in one fragment since the limit of coordinator (#28114)

Browse Source
This commit is contained in:
morrySnow
2023-12-07 19:58:31 +08:00
committed by GitHub
parent cc9b4bcddb
commit 65fc2e0438
3 changed files with 5 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/table/Numbers.java
View File

@ -22,7 +22,6 @@ import org.apache.doris.catalog.FunctionSignature;
import org.apache.doris.catalog.Type;
import org.apache.doris.common.NereidsException;
import org.apache.doris.nereids.exceptions.AnalysisException;
import org.apache.doris.nereids.properties.PhysicalProperties;
import org.apache.doris.nereids.trees.expressions.Expression;
import org.apache.doris.nereids.trees.expressions.Properties;
import org.apache.doris.nereids.trees.expressions.Slot;
@ -88,16 +87,6 @@ public class Numbers extends TableValuedFunction {
return visitor.visitNumbers(this, context);
}
@Override
public PhysicalProperties getPhysicalProperties() {
// TODO: use gather after coordinator support plan gather scan
// String backendNum = getTVFProperties().getMap().getOrDefault(NumbersTableValuedFunction.BACKEND_NUM, "1");
// if (backendNum.trim().equals("1")) {
// return PhysicalProperties.GATHER;
// }
return PhysicalProperties.ANY;
}
@Override
public Numbers withChildren(List<Expression> children) {
Preconditions.checkArgument(children().size() == 1

2
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/table/TableValuedFunction.java
View File

@ -109,7 +109,7 @@ public abstract class TableValuedFunction extends BoundFunction implements Unary
}
public PhysicalProperties getPhysicalProperties() {
return PhysicalProperties.ANY;
return PhysicalProperties.STORAGE_ANY;
}
@Override

4
regression-test/suites/nereids_function_p0/tvf/tvf.groovy
View File

@ -32,4 +32,8 @@ suite("nereids_tvf") {
sql """
select QueryId from queries() where `Sql` like "%test_queries_tvf%";
"""
sql """
select * from numbers("number" = "1") union all select * from numbers("number" = "1");
"""
}