database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

[improvement](statistics)Only write editlog for manual analyze task, don't need to do so for auto tasks. #29685

Browse Source 
Only write editlog for manual analyze task, don't need to do so for auto tasks to reduce writing editlog.
Add error message to job info while task failed.
This commit is contained in:
Jibing-Li
2024-01-09 15:03:06 +08:00
committed by yiguolei
parent 374c638788
commit 7357ca62af
1 changed files with 10 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
fe/fe-core/src/main/java/org/apache/doris/statistics/AnalysisManager.java
View File

@ -483,7 +483,12 @@ public class AnalysisManager implements Writable {
if (taskState.equals(AnalysisState.FINISHED) || taskState.equals(AnalysisState.FAILED)) {
info.timeCostInMs = time - info.lastExecTimeInMs;
info.lastExecTimeInMs = time;
logCreateAnalysisTask(info);
// Persist task info for manual job.
if (info.jobType.equals(JobType.MANUAL)) {
logCreateAnalysisTask(info);
} else {
replayCreateAnalysisTask(info);
}
}
info.lastExecTimeInMs = time;
AnalysisInfo job = analysisJobInfoMap.get(info.jobId);
@ -494,6 +499,10 @@ public class AnalysisManager implements Writable {
// Synchronize the job state change in job level.
synchronized (job) {
job.lastExecTimeInMs = time;
if (taskState.equals(AnalysisState.FAILED)) {
String errMessage = String.format("%s:[%s] ", info.colName, message);
job.message = job.message == null ? errMessage : job.message + errMessage;
}
// Set the job state to RUNNING when its first task becomes RUNNING.
if (info.state.equals(AnalysisState.RUNNING) && job.state.equals(AnalysisState.PENDING)) {
job.state = AnalysisState.RUNNING;