database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

[minor](conjuncts) remove row-based conjuncts from vectorized engine (#12053)

Browse Source
This commit is contained in:
Gabriel
2022-08-25 10:13:20 +08:00
committed by GitHub
parent 6e6de1853c
commit 73a3471fbd
5 changed files with 0 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
be/src/vec/exec/vaggregation_node.cpp
View File

@ -94,7 +94,6 @@ AggregationNode::AggregationNode(ObjectPool* pool, const TPlanNode& tnode,
if (tnode.agg_node.__isset.use_streaming_preaggregation) {
_is_streaming_preagg = tnode.agg_node.use_streaming_preaggregation;
if (_is_streaming_preagg) {
DCHECK(_conjunct_ctxs.empty()) << "Preaggs have no conjuncts";
DCHECK(!tnode.agg_node.grouping_exprs.empty()) << "Streaming preaggs do grouping";
DCHECK(_limit == -1) << "Preaggs have no limits";
}

1
be/src/vec/exec/volap_scanner.cpp
View File

@ -384,7 +384,6 @@ Status VOlapScanner::close(RuntimeState* state) {
_tablet_reader_params.rs_readers.clear();
update_counter();
_tablet_reader.reset();
Expr::close(_conjunct_ctxs, state);
_is_closed = true;
return Status::OK();
}

3
be/src/vec/exec/volap_scanner.h
View File

@ -57,8 +57,6 @@ public:
RuntimeState* runtime_state() { return _runtime_state; }
std::vector<ExprContext*>* conjunct_ctxs() { return &_conjunct_ctxs; }
VExprContext** vconjunct_ctx_ptr() { return &_vconjunct_ctx; }
void discard_conjuncts() {
@ -110,7 +108,6 @@ private:
VOlapScanNode* _parent;
const TupleDescriptor* _tuple_desc; /**< tuple descriptor */
std::vector<ExprContext*> _conjunct_ctxs;
// to record which runtime filters have been used
std::vector<bool> _runtime_filter_marks;

1
be/src/vec/exec/vset_operation_node.cpp
View File

@ -90,7 +90,6 @@ Status VSetOperationNode::close(RuntimeState* state) {
Status VSetOperationNode::init(const TPlanNode& tnode, RuntimeState* state) {
RETURN_IF_ERROR(ExecNode::init(tnode, state));
DCHECK_EQ(_conjunct_ctxs.size(), 0);
std::vector<std::vector<::doris::TExpr>> result_texpr_lists;
// Create result_expr_ctx_lists_ from thrift exprs.

1
be/src/vec/exec/vunion_node.cpp
View File

@ -42,7 +42,6 @@ VUnionNode::VUnionNode(ObjectPool* pool, const TPlanNode& tnode, const Descripto
Status VUnionNode::init(const TPlanNode& tnode, RuntimeState* state) {
RETURN_IF_ERROR(ExecNode::init(tnode, state));
DCHECK(tnode.__isset.union_node);
DCHECK_EQ(_conjunct_ctxs.size(), 0);
// Create const_expr_ctx_lists_ from thrift exprs.
auto& const_texpr_lists = tnode.union_node.const_expr_lists;
for (auto& texprs : const_texpr_lists) {