database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

[fix](Nereids) round function return type should be double (#15502)

Browse Source
This commit is contained in:
morrySnow
2022-12-30 23:36:15 +08:00
committed by GitHub
parent 96518db263
commit 781fa17993
4 changed files with 24 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/scalar/Round.java
View File

@ -22,7 +22,6 @@ import org.apache.doris.nereids.trees.expressions.Expression;
import org.apache.doris.nereids.trees.expressions.functions.ExplicitlyCastableSignature;
import org.apache.doris.nereids.trees.expressions.functions.PropagateNullable;
import org.apache.doris.nereids.trees.expressions.visitor.ExpressionVisitor;
import org.apache.doris.nereids.types.BigIntType;
import org.apache.doris.nereids.types.DoubleType;
import org.apache.doris.nereids.types.IntegerType;
@ -38,7 +37,7 @@ public class Round extends ScalarFunction
implements ExplicitlyCastableSignature, PropagateNullable {
public static final List<FunctionSignature> SIGNATURES = ImmutableList.of(
FunctionSignature.ret(BigIntType.INSTANCE).args(DoubleType.INSTANCE),
FunctionSignature.ret(DoubleType.INSTANCE).args(DoubleType.INSTANCE),
FunctionSignature.ret(DoubleType.INSTANCE).args(DoubleType.INSTANCE, IntegerType.INSTANCE)
);

3
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/scalar/RoundBankers.java
View File

@ -22,7 +22,6 @@ import org.apache.doris.nereids.trees.expressions.Expression;
import org.apache.doris.nereids.trees.expressions.functions.ExplicitlyCastableSignature;
import org.apache.doris.nereids.trees.expressions.functions.PropagateNullable;
import org.apache.doris.nereids.trees.expressions.visitor.ExpressionVisitor;
import org.apache.doris.nereids.types.BigIntType;
import org.apache.doris.nereids.types.DoubleType;
import org.apache.doris.nereids.types.IntegerType;
@ -38,7 +37,7 @@ public class RoundBankers extends ScalarFunction
implements ExplicitlyCastableSignature, PropagateNullable {
public static final List<FunctionSignature> SIGNATURES = ImmutableList.of(
FunctionSignature.ret(BigIntType.INSTANCE).args(DoubleType.INSTANCE),
FunctionSignature.ret(DoubleType.INSTANCE).args(DoubleType.INSTANCE),
FunctionSignature.ret(DoubleType.INSTANCE).args(DoubleType.INSTANCE, IntegerType.INSTANCE)
);

12
regression-test/data/query_p0/sql_functions/math_functions/test_round.out
View File

@ -26,3 +26,15 @@
-- !select --
16.020 16.02000 16.02000
-- !nereids_round_arg1 --
10.0
-- !nereids_round_arg2 --
10.12
-- !nereids_round_bankers_arg1 --
10.0
-- !nereids_round_bankers_arg2 --
10.12

10
regression-test/suites/query_p0/sql_functions/math_functions/test_round.groovy
View File

@ -37,4 +37,14 @@ suite("test_round") {
qt_select """ SELECT truncate(col1, 2), truncate(col2, 2), truncate(col3, 2) FROM `${tableName}`; """
qt_select """ SELECT round_bankers(col1, 2), round_bankers(col2, 2), round_bankers(col3, 2) FROM `${tableName}`; """
sql """ DROP TABLE IF EXISTS `${tableName}` """
sql "SET enable_nereids_planner=true"
sql "SET enable_vectorized_engine=true"
sql "SET enable_fallback_to_original_planner=false"
qt_nereids_round_arg1 "SELECT round(10.12345)"
qt_nereids_round_arg2 "SELECT round(10.12345, 2)"
qt_nereids_round_bankers_arg1 "SELECT round_bankers(10.12345)"
qt_nereids_round_bankers_arg2 "SELECT round_bankers(10.12345, 2)"
}