[optimization] use inline optimize ExprContext::get_value (#5385)

be/src/exec/base_scanner.cpp

@@ -19,6 +19,7 @@
 
 #include "common/logging.h"
 #include "exec/exec_node.h"
+#include "exprs/expr_context.h"
 #include "runtime/descriptors.h"
 #include "runtime/mem_tracker.h"
 #include "runtime/raw_value.h"

be/src/exec/broker_scan_node.cpp

@@ -26,6 +26,7 @@
 #include "exec/orc_scanner.h"
 #include "exec/parquet_scanner.h"
 #include "exprs/expr.h"
+#include "exprs/expr_context.h"
 #include "runtime/dpp_sink_internal.h"
 #include "runtime/row_batch.h"
 #include "runtime/runtime_state.h"

be/src/exec/es_http_scan_node.cpp

@@ -26,6 +26,7 @@
 #include "exec/es/es_scan_reader.h"
 #include "exec/es/es_scroll_query.h"
 #include "exprs/expr.h"
+#include "exprs/expr_context.h"
 #include "runtime/dpp_sink_internal.h"
 #include "runtime/row_batch.h"
 #include "runtime/runtime_state.h"

be/src/exec/es_http_scanner.cpp

@@ -21,6 +21,7 @@
 #include <sstream>
 
 #include "exprs/expr.h"
+#include "exprs/expr_context.h"
 #include "runtime/descriptors.h"
 #include "runtime/exec_env.h"
 #include "runtime/mem_tracker.h"

be/src/exec/hash_join_node.cpp

@@ -21,6 +21,7 @@
 
 #include "exec/hash_table.hpp"
 #include "exprs/expr.h"
+#include "exprs/expr_context.h"
 #include "exprs/in_predicate.h"
 #include "exprs/slot_ref.h"
 #include "gen_cpp/PlanNodes_types.h"

be/src/exec/hash_table.cpp

@@ -18,6 +18,7 @@
 #include "exec/hash_table.hpp"
 
 #include "exprs/expr.h"
+#include "exprs/expr_context.h"
 #include "runtime/mem_tracker.h"
 #include "runtime/raw_value.h"
 #include "runtime/runtime_state.h"

be/src/exec/merge_join_node.cpp

@@ -20,6 +20,7 @@
 #include <sstream>
 
 #include "exprs/expr.h"
+#include "exprs/expr_context.h"
 #include "exprs/in_predicate.h"
 #include "gen_cpp/PlanNodes_types.h"
 #include "runtime/row_batch.h"

be/src/exec/merge_node.cpp

@@ -18,6 +18,7 @@
 #include "exec/merge_node.h"
 
 #include "exprs/expr.h"
+#include "exprs/expr_context.h"
 #include "gen_cpp/PlanNodes_types.h"
 #include "runtime/raw_value.h"
 #include "runtime/row_batch.h"

be/src/exec/olap_rewrite_node.cpp

@@ -20,6 +20,7 @@
 #include <sstream>
 
 #include "exprs/expr.h"
+#include "exprs/expr_context.h"
 #include "runtime/descriptors.h"
 #include "runtime/raw_value.h"
 #include "runtime/row_batch.h"

be/src/exec/olap_scan_node.cpp

@@ -30,6 +30,7 @@
 #include "common/resource_tls.h"
 #include "exprs/binary_predicate.h"
 #include "exprs/expr.h"
+#include "exprs/expr_context.h"
 #include "gen_cpp/PlanNodes_types.h"
 #include "runtime/exec_env.h"
 #include "runtime/row_batch.h"

be/src/exec/set_operation_node.cpp

@@ -19,6 +19,7 @@
 
 #include "exec/hash_table.hpp"
 #include "exprs/expr.h"
+#include "exprs/expr_context.h"
 #include "runtime/raw_value.h"
 #include "runtime/row_batch.h"
 #include "runtime/runtime_state.h"

be/src/exec/tablet_sink.cpp

@@ -20,6 +20,7 @@
 #include <sstream>
 
 #include "exprs/expr.h"
+#include "exprs/expr_context.h"
 #include "olap/hll.h"
 #include "runtime/exec_env.h"
 #include "runtime/row_batch.h"

be/src/exprs/case_expr.cpp

@@ -17,6 +17,7 @@
 
 #include "exprs/case_expr.h"
 
+#include "exprs/expr_context.h"
 #include "exprs/anyval_util.h"
 #include "gen_cpp/Exprs_types.h"
 #include "runtime/runtime_state.h"

be/src/exprs/expr.cpp

@@ -32,6 +32,7 @@
 #include "exprs/cast_expr.h"
 #include "exprs/compound_predicate.h"
 #include "exprs/conditional_functions.h"
+#include "exprs/expr_context.h"
 #include "exprs/in_predicate.h"
 #include "exprs/info_func.h"
 #include "exprs/is_null_predicate.h"

be/src/exprs/expr.h

@@ -23,7 +23,6 @@
 #include <vector>
 
 #include "common/status.h"
-#include "exprs/expr_context.h"
 #include "exprs/expr_value.h"
 #include "gen_cpp/Opcodes_types.h"
 #include "runtime/datetime_value.h"
@@ -46,6 +45,7 @@ USING_DORIS_UDF;
 namespace doris {
 
 class Expr;
+class ExprContext;
 class ObjectPool;
 class RowDescriptor;
 class RuntimeState;

be/src/exprs/expr_context.cpp

@@ -244,13 +244,6 @@ void ExprContext::get_value(TupleRow* row, bool as_ascii, TColumnValue* col_val)
 #endif
 }
 
-void* ExprContext::get_value(TupleRow* row) {
-    if (_root->is_slotref()) {
-        return SlotRef::get_value(_root, row);
-    }
-    return get_value(_root, row);
-}
-
 bool ExprContext::is_nullable() {
     if (_root->is_slotref()) {
         return SlotRef::is_nullable(_root);

be/src/exprs/expr_context.h

@@ -22,6 +22,8 @@
 
 #include "common/status.h"
 #include "exprs/expr_value.h"
+#include "exprs/expr.h"
+#include "exprs/slot_ref.h"
 #include "udf/udf.h"
 #include "udf/udf_internal.h" // for ArrayVal
 
@@ -206,6 +208,13 @@ private:
     void* get_value(Expr* e, TupleRow* row);
 };
 
+inline void* ExprContext::get_value(TupleRow* row) {
+    if (_root->is_slotref()) {
+        return SlotRef::get_value(_root, row);
+    }
+    return get_value(_root, row);
+}
+
 } // namespace doris
 
 #endif

be/src/exprs/in_predicate.cpp

@@ -19,6 +19,7 @@
 
 #include <sstream>
 
+#include "exprs/expr_context.h"
 #include "exprs/anyval_util.h"
 #include "runtime/raw_value.h"
 #include "runtime/runtime_state.h"

be/src/exprs/timestamp_functions.cpp

@@ -19,6 +19,7 @@
 
 #include "exprs/anyval_util.h"
 #include "exprs/expr.h"
+#include "exprs/expr_context.h"
 #include "runtime/datetime_value.h"
 #include "runtime/runtime_state.h"
 #include "runtime/string_value.hpp"

be/src/runtime/data_spliter.cpp

@@ -23,6 +23,7 @@
 
 #include "common/object_pool.h"
 #include "exprs/expr.h"
+#include "exprs/expr_context.h"
 #include "gen_cpp/DataSinks_types.h"
 #include "runtime/dpp_sink.h"
 #include "runtime/load_path_mgr.h"

be/src/runtime/data_stream_sender.cpp

@@ -26,6 +26,7 @@
 
 #include "common/logging.h"
 #include "exprs/expr.h"
+#include "exprs/expr_context.h"
 #include "gen_cpp/BackendService.h"
 #include "gen_cpp/PaloInternalService_types.h"
 #include "gen_cpp/Types_types.h"

be/src/runtime/dpp_sink.cpp

@@ -23,6 +23,7 @@
 #include "agent/cgroups_mgr.h"
 #include "common/object_pool.h"
 #include "exprs/expr.h"
+#include "exprs/expr_context.h"
 #include "exprs/slot_ref.h"
 #include "gen_cpp/Types_types.h"
 #include "olap/field.h"

be/src/runtime/dpp_writer.cpp

@@ -22,6 +22,7 @@
 #include <vector>
 
 #include "exprs/expr.h"
+#include "exprs/expr_context.h"
 #include "olap/utils.h"
 #include "runtime/primitive_type.h"
 #include "runtime/row_batch.h"

be/src/runtime/export_sink.cpp

@@ -24,6 +24,7 @@
 #include "exec/broker_writer.h"
 #include "exec/local_file_writer.h"
 #include "exprs/expr.h"
+#include "exprs/expr_context.h"
 #include "runtime/mem_tracker.h"
 #include "runtime/mysql_table_sink.h"
 #include "runtime/row_batch.h"

be/src/runtime/file_result_writer.cpp

@@ -21,6 +21,7 @@
 #include "exec/local_file_writer.h"
 #include "exec/parquet_writer.h"
 #include "exprs/expr.h"
+#include "exprs/expr_context.h"
 #include "gen_cpp/PaloInternalService_types.h"
 #include "runtime/primitive_type.h"
 #include "runtime/row_batch.h"

be/src/runtime/mysql_result_writer.cpp

@@ -18,6 +18,7 @@
 #include "runtime/mysql_result_writer.h"
 
 #include "exprs/expr.h"
+#include "exprs/expr_context.h"
 #include "gen_cpp/PaloInternalService_types.h"
 #include "runtime/buffer_control_block.h"
 #include "runtime/primitive_type.h"

be/src/runtime/mysql_table_writer.cpp

@@ -21,6 +21,7 @@
 #include <sstream>
 
 #include "exprs/expr.h"
+#include "exprs/expr_context.h"
 #include "runtime/mysql_table_writer.h"
 #include "runtime/row_batch.h"
 #include "runtime/tuple_row.h"

be/src/runtime/qsorter.cpp

@@ -20,6 +20,7 @@
 #include <algorithm>
 
 #include "exprs/expr.h"
+#include "exprs/expr_context.h"
 #include "runtime/descriptors.h"
 #include "runtime/raw_value.h"
 #include "runtime/row_batch.h"

be/src/runtime/tuple.cpp

@@ -20,6 +20,7 @@
 #include <vector>
 
 #include "exprs/expr.h"
+#include "exprs/expr_context.h"
 #include "runtime/descriptors.h"
 #include "runtime/mem_pool.h"
 #include "runtime/raw_value.h"

be/src/util/tuple_row_compare.h

@@ -20,6 +20,7 @@
 
 #include "exec/sort_exec_exprs.h"
 #include "exprs/expr.h"
+#include "exprs/expr_context.h"
 #include "runtime/descriptors.h"
 #include "runtime/raw_value.h"
 #include "runtime/tuple.h"

be/test/exec/hash_table_test.cpp

@@ -29,6 +29,7 @@
 
 #include "common/compiler_util.h"
 #include "exprs/expr.h"
+#include "exprs/expr_context.h"
 #include "exprs/slot_ref.h"
 #include "runtime/exec_env.h"
 #include "runtime/mem_pool.h"

be/test/exprs/math_functions_test.cpp

@@ -23,6 +23,7 @@
 #include <string>
 
 #include "exprs/anyval_util.h"
+#include "exprs/expr_context.h"
 #include "testutil/function_utils.h"
 #include "util/logging.h"
 

be/test/exprs/topn_function_test.cpp

@@ -16,6 +16,7 @@
 // under the License.
 
 #include "exprs/anyval_util.h"
+#include "exprs/expr_context.h"
 #include "exprs/topn_function.h"
 #include "util/topn_counter.h"
 #include "testutil/function_utils.h"