database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

Only UDA function could be supported in correlated subquery

Browse Source 
Those query of issue could not be supported. #2483 #2493
Those query is forbidden:
query1: select * from t1 where k1=(select k1 from t2 where t1.k2=t2.k2);
query2: select * from t1 where k1=(select distinct k1 from t2 where t1.k2=t2.k2);
Only sum, max, min, avg and count function could appear on select clause for correlated subquery. #2420
Those query is legal:
query1: select * from t1 where k1=(select avg(k1) from t2 where t1.k2=t2.k2);
This commit is contained in:
emmymiao87
2019-12-18 14:50:32 +08:00
parent 3e58e2d543
commit 8342eb0b02
2 changed files with 29 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
fe/src/main/java/org/apache/doris/analysis/Expr.java
View File

@ -123,6 +123,24 @@ abstract public class Expr extends TreeNode<Expr> implements ParseNode, Cloneabl
}
};
*/
// Returns true if an Expr is a builtin aggregate function.
public final static com.google.common.base.Predicate<Expr> IS_BUILTIN_AGG_FN =
new com.google.common.base.Predicate<Expr>() {
@Override
public boolean apply(Expr arg) {
if (arg instanceof FunctionCallExpr) {
String fnName = ((FunctionCallExpr)arg).getFnName().getFunction();
return (fnName.equalsIgnoreCase("sum")
|| fnName.equalsIgnoreCase("max")
|| fnName.equalsIgnoreCase("min")
|| fnName.equalsIgnoreCase("avg")
|| fnName.equalsIgnoreCase("count"));
} else {
return false;
}
}
};
public final static com.google.common.base.Predicate<Expr> IS_TRUE_LITERAL =
new com.google.common.base.Predicate<Expr>() {

15
fe/src/main/java/org/apache/doris/analysis/StmtRewriter.java
View File

@ -744,10 +744,17 @@ public class StmtRewriter {
Preconditions.checkNotNull(stmt);
// Grouping and/or aggregation (including analytic functions) is only
// allowed on correlated EXISTS subqueries
if ((expr instanceof BinaryPredicate
&& (stmt.hasAggInfo() || stmt.hasAnalyticInfo()))
|| (expr instanceof InPredicate
&& (stmt.hasAggInfo() || stmt.hasAnalyticInfo()))) {
if (expr instanceof BinaryPredicate) {
if (stmt.getSelectList().getItems().size() != 1) {
throw new AnalysisException("The subquery only support one item in select clause");
}
SelectListItem item = stmt.getSelectList().getItems().get(0);
if (!item.getExpr().contains(Expr.IS_BUILTIN_AGG_FN)) {
throw new AnalysisException("The select item of correlated subquery should only be sum, min, max, avg"
+ " and count. Current subquery:" + stmt.toSql());
}
}
if (expr instanceof InPredicate && (stmt.hasAggInfo() || stmt.hasAnalyticInfo())) {
LOG.warn("canRewriteCorrelatedSubquery fail, expr={} subquery={}", expr.toSql(), stmt.toSql());
throw new AnalysisException("Unsupported correlated subquery with grouping "
+ "and/or aggregation: "