database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

[fix](function) json_object can not input null value (#34591)

Browse Source
This commit is contained in:
Mryange
2024-05-11 14:17:43 +08:00
committed by yiguolei
parent 7e967e53b8
commit 876248aa4e
2 changed files with 27 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
be/src/vec/functions/function_json.cpp
View File

@ -619,6 +619,7 @@ struct ExecuteReducer {
struct FunctionJsonArrayImpl {
static constexpr auto name = "json_array";
static constexpr auto must_not_null = false;
template <int flag>
using Reducer = ExecuteReducer<flag, FunctionJsonArrayImpl>;
@ -654,7 +655,7 @@ struct FunctionJsonArrayImpl {
struct FunctionJsonObjectImpl {
static constexpr auto name = "json_object";
static constexpr auto must_not_null = true;
template <int flag>
using Reducer = ExecuteReducer<flag, FunctionJsonObjectImpl>;
@ -743,6 +744,9 @@ public:
data_columns.push_back(assert_cast<const ColumnString*>(column_ptrs.back().get()));
}
}
if (SpecificImpl::must_not_null) {
RETURN_IF_ERROR(check_keys_all_not_null(nullmaps, input_rows_count, arguments.size()));
}
execute(data_columns, *assert_cast<ColumnString*>(result_column.get()), input_rows_count,
nullmaps);
block.get_by_position(result).column = std::move(result_column);
@ -774,6 +778,24 @@ public:
result_column.insert_data(buf.GetString(), buf.GetSize());
}
}
static Status check_keys_all_not_null(const std::vector<const ColumnUInt8*>& nullmaps, int size,
size_t args) {
for (int i = 0; i < args; i += 2) {
const auto* null_map = nullmaps[i];
if (null_map) {
const bool not_null_num =
simd::count_zero_num((int8_t*)null_map->get_data().data(), size);
if (not_null_num < size) {
return Status::InternalError(
"function {} can not input null value , JSON documents may not contain "
"NULL member names.",
name);
}
}
}
return Status::OK();
}
};
struct FunctionJsonQuoteImpl {

4
regression-test/suites/query_p0/sql_functions/json_function/test_query_json_object.groovy
View File

@ -41,5 +41,9 @@ suite("test_query_json_object", "query") {
sql "insert into ${tableName} values(4,null,null,'test','2022-01-01 11:11:11');"
sql "insert into ${tableName} values(5,1,true,'test','2022-01-01 11:11:11');"
qt_sql1 "select json_object('k0',k0,'k1',k1,'k2',k2,'k3',k3,'k4',k4,'k5', null,'k6','k6') from ${tableName} order by k0;"
test {
sql """select k0,json_object(k3,123) from ${tableName} order by k0;"""
exception "[CANCELLED][INTERNAL_ERROR] function json_object can not input null value , JSON documents may not contain NULL member names."
}
sql "DROP TABLE ${tableName};"
}