database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

[feature-wip](unique-key-merge-on-write) unique key table with MOW supports delete sign column (#11672)

Browse Source
This commit is contained in:
Xin Liao
2022-08-17 15:12:11 +08:00
committed by GitHub
parent 7df8c6f493
commit 98243e99ae
2 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
fe/fe-core/src/main/java/org/apache/doris/analysis/CreateTableStmt.java
View File

@ -376,9 +376,9 @@ public class CreateTableStmt extends DdlStmt {
if (Config.enable_batch_delete_by_default
&& keysDesc != null
&& keysDesc.getKeysType() == KeysType.UNIQUE_KEYS) {
// TODO(zhangchen): Disable the delete sign column for primary key temporary, will replace
// with a better solution later.
if (!enableUniqueKeyMergeOnWrite) {
if (enableUniqueKeyMergeOnWrite) {
columnDefs.add(ColumnDef.newDeleteSignColumnDef(AggregateType.NONE));
} else {
columnDefs.add(ColumnDef.newDeleteSignColumnDef(AggregateType.REPLACE));
}
}

4
fe/fe-core/src/main/java/org/apache/doris/catalog/Column.java
View File

@ -241,7 +241,9 @@ public class Column implements Writable {
}
public boolean isDeleteSignColumn() {
return !visible && aggregationType == AggregateType.REPLACE && nameEquals(DELETE_SIGN, true);
// aggregationType is NONE for unique table with merge on write.
return !visible && (aggregationType == AggregateType.REPLACE
|| aggregationType == AggregateType.NONE) && nameEquals(DELETE_SIGN, true);
}
public boolean isSequenceColumn() {